Always Pass skaffold binary in post-render to add labels for status-check#8826
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
ad6b6c1 to
983da86
Compare
|
@ericzzzzzzz Integration test seems to work fine in my local. In the github actions, I don't see the option to re-trigger the test pipeline. Can you please check this ? |
|
@ericzzzzzzz There is a different error message for the same test. Can you please check this once ? In local it is working as expected - |
0db0845 to
d77008d
Compare
…tus-check Author: <rajeshayaldasani.cse18@gmail.com>
d77008d to
1344037
Compare
|
@ericzzzzzzz Can you please trigger the PR checks. I have increased |
Codecov Report
@@ Coverage Diff @@
## main #8826 +/- ##
==========================================
- Coverage 70.48% 63.91% -6.58%
==========================================
Files 515 620 +105
Lines 23150 31473 +8323
==========================================
+ Hits 16317 20115 +3798
- Misses 5776 9852 +4076
- Partials 1057 1506 +449
... and 410 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@ericzzzzzzz Does the PR look good enough to merge into master ? |
…
Fixes: #8742
Description
Passing skaffold binary in post-render to add labels for status-check
User facing changes (remove if N/A)
Follow-up Work (remove if N/A)