Skip to content

Always Pass skaffold binary in post-render to add labels for status-check#8826

Merged
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
Rajesh-Ayaldasani:fix/status-check
Jun 8, 2023
Merged

Always Pass skaffold binary in post-render to add labels for status-check#8826
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
Rajesh-Ayaldasani:fix/status-check

Conversation

@Rajesh-Ayaldasani

@Rajesh-Ayaldasani Rajesh-Ayaldasani commented May 26, 2023

Copy link
Copy Markdown
Contributor

Fixes: #8742

Description

Passing skaffold binary in post-render to add labels for status-check

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

@google-cla

google-cla Bot commented May 26, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Rajesh-Ayaldasani Rajesh-Ayaldasani changed the title Pass skaffold binary in post-render always to add labels for status-check May 26, 2023
@conventional-commit-lint-gcf

conventional-commit-lint-gcf Bot commented May 26, 2023

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@Rajesh-Ayaldasani Rajesh-Ayaldasani force-pushed the fix/status-check branch 11 times, most recently from ad6b6c1 to 983da86 Compare May 26, 2023 18:10
@pull-request-size pull-request-size Bot added size/S and removed size/M labels May 26, 2023
@Rajesh-Ayaldasani

Copy link
Copy Markdown
Contributor Author
@Rajesh-Ayaldasani

Copy link
Copy Markdown
Contributor Author

@ericzzzzzzz Integration test seems to work fine in my local. In the github actions, I don't see the option to re-trigger the test pipeline. Can you please check this ?

@Rajesh-Ayaldasani

Rajesh-Ayaldasani commented Jun 6, 2023

Copy link
Copy Markdown
Contributor Author

@ericzzzzzzz There is a different error message for the same test. Can you please check this once ?

In local it is working as expected -

time="2023-06-06T18:48:13+05:30" level=info msg="Namespace: skaffoldqrzlk" subtask=-1 task=DevLoop
    /Users/rajesh/Desktop/github/skaffold/integration/run_test.go:451: Running [skaffold run --namespace skaffoldqrzlk --default-repo us-central1-docker.pkg.dev/k8s-skaffold/testing] in testdata/unstable-deployment
--- PASS: TestRunUnstableChecked (8.56s)
PASS
ok      github.com/GoogleContainerTools/skaffold/v2/integration 9.129s```
…tus-check

Author: <rajeshayaldasani.cse18@gmail.com>
@Rajesh-Ayaldasani

Copy link
Copy Markdown
Contributor Author

@ericzzzzzzz Can you please trigger the PR checks. I have increased progressDeadlineSeconds to 20 seconds to test it out.

@codecov

codecov Bot commented Jun 7, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8826 (1344037) into main (290280e) will decrease coverage by 6.58%.
The diff coverage is 50.10%.

@@            Coverage Diff             @@
##             main    #8826      +/-   ##
==========================================
- Coverage   70.48%   63.91%   -6.58%     
==========================================
  Files         515      620     +105     
  Lines       23150    31473    +8323     
==========================================
+ Hits        16317    20115    +3798     
- Misses       5776     9852    +4076     
- Partials     1057     1506     +449     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 410 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Rajesh-Ayaldasani

Copy link
Copy Markdown
Contributor Author

@ericzzzzzzz Does the PR look good enough to merge into master ?

@ericzzzzzzz ericzzzzzzz merged commit e7ce14b into GoogleContainerTools:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants