Skip to content

test: increase progressDeadlineSeconds timeout for TestRunUnstableChecked#8833

Merged
renzodavid9 merged 1 commit into
GoogleContainerTools:mainfrom
renzodavid9:issue-8822
May 30, 2023
Merged

test: increase progressDeadlineSeconds timeout for TestRunUnstableChecked#8833
renzodavid9 merged 1 commit into
GoogleContainerTools:mainfrom
renzodavid9:issue-8822

Conversation

@renzodavid9

@renzodavid9 renzodavid9 commented May 29, 2023

Copy link
Copy Markdown
Contributor

Related: #8822

Description
The TestRunUnstableChecked integration test is failing due to it reaches the deadline specified in Deployment.spec.progressDeadlineSeconds before reaching the expected error in the test; the Deployment.spec.progressDeadlineSeconds is used to configure the status check timeout. This PR increase the deadline.

Follow-up Work
Add the change in the different LTS branches

@renzodavid9 renzodavid9 changed the title Issue 8822 May 29, 2023
@codecov

codecov Bot commented May 29, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8833 (1c84861) into main (290280e) will decrease coverage by 6.53%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #8833      +/-   ##
==========================================
- Coverage   70.48%   63.95%   -6.53%     
==========================================
  Files         515      620     +105     
  Lines       23150    31455    +8305     
==========================================
+ Hits        16317    20118    +3801     
- Misses       5776     9833    +4057     
- Partials     1057     1504     +447     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 409 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 changed the title test: fix TestRunUnstableChecked May 29, 2023
@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label May 29, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label May 29, 2023
@renzodavid9 renzodavid9 marked this pull request as ready for review May 30, 2023 13:24

@plumpy plumpy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@renzodavid9 renzodavid9 merged commit ebda959 into GoogleContainerTools:main May 30, 2023
renzodavid9 added a commit to renzodavid9/skaffold that referenced this pull request May 31, 2023
renzodavid9 added a commit to renzodavid9/skaffold that referenced this pull request May 31, 2023
renzodavid9 added a commit to renzodavid9/skaffold that referenced this pull request May 31, 2023
plumpy pushed a commit that referenced this pull request May 31, 2023
plumpy pushed a commit that referenced this pull request May 31, 2023
renzodavid9 added a commit to renzodavid9/skaffold that referenced this pull request Jun 3, 2023
renzodavid9 added a commit that referenced this pull request Jun 5, 2023
renzodavid9 added a commit to renzodavid9/skaffold that referenced this pull request Jun 9, 2023
renzodavid9 added a commit that referenced this pull request Jun 9, 2023
…ange in baseRef (#8878)

* test: increase progressDeadlineSeconds timeout to make TestRunUnstableChecked pass (#8833)

(cherry picked from commit ebda959)

* fix: change baseRef to release/v2.5 branch for schema changes test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants