Skip to content

chore: cherry-pick scanning marker change to release/v2.3#8842

Merged
ericzzzzzzz merged 5 commits into
GoogleContainerTools:release/v2.3from
ericzzzzzzz:cherry-pick-scanning-marker-change-v2.3
Jun 2, 2023
Merged

chore: cherry-pick scanning marker change to release/v2.3#8842
ericzzzzzzz merged 5 commits into
GoogleContainerTools:release/v2.3from
ericzzzzzzz:cherry-pick-scanning-marker-change-v2.3

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

Related

@ericzzzzzzz ericzzzzzzz changed the title chore: update release build script to support internal scanning (#8834) Jun 1, 2023
@pull-request-size pull-request-size Bot added size/S and removed size/XS labels Jun 1, 2023
@codecov

codecov Bot commented Jun 1, 2023

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (release/v2.3@c7e1131). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release/v2.3    #8842   +/-   ##
===============================================
  Coverage                ?   64.25%           
===============================================
  Files                   ?      613           
  Lines                   ?    30618           
  Branches                ?        0           
===============================================
  Hits                    ?    19674           
  Misses                  ?     9467           
  Partials                ?     1477           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size Bot added size/L and removed size/S labels Jun 1, 2023
@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review June 2, 2023 15:14
@ericzzzzzzz ericzzzzzzz requested a review from a team as a code owner June 2, 2023 15:14
@ericzzzzzzz ericzzzzzzz requested review from a team, gsquared94, plumpy, renzodavid9 and tejal29 and removed request for a team, gsquared94 and tejal29 June 2, 2023 15:14
@renzodavid9

renzodavid9 commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

I was checking why does the release/v2.0 branch tests were not failing with the same error about the schema version (hack/check-schema-changes.sh and hack/check-samples.sh). Looks like we just disabled those scripts, so the check is not run (Commit: 147129a). Not sure if it make sense to do the same for this branch so we have the same solution for both branches, what do you think?

Also, it looks like skaffold v2.0.x uses the v4beta1 🤔 schema

@ericzzzzzzz

Copy link
Copy Markdown
Contributor Author

I was checking why does the release/v2.0 branch tests were not failing with the same error about the schema version (hack/check-schema-changes.sh and hack/check-samples.sh). Looks like we just disabled those scripts, so the check is not run (Commit: 147129a). Not sure if it make sense to do the same for this branch so we have the same solution for both branches, what do you think?

Also, it looks like skaffold v2.0.x uses the v4beta1 🤔 schema

oh I'm fine with either way.

@ericzzzzzzz ericzzzzzzz merged commit 8469fea into GoogleContainerTools:release/v2.3 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants