fix: logic to interrupt a k8sjob logs as soon as it fails#8847
Merged
Conversation
…in delete order, now the job is deleted before its pods
Codecov Report
@@ Coverage Diff @@
## main #8847 +/- ##
==========================================
- Coverage 70.48% 63.94% -6.55%
==========================================
Files 515 620 +105
Lines 23150 31463 +8313
==========================================
+ Hits 16317 20118 +3801
- Misses 5776 9841 +4065
- Partials 1057 1504 +447
... and 410 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
renzodavid9
added
kokoro:run
ericzzzzzzz
approved these changes
Jun 8, 2023
renzodavid9
added a commit
to renzodavid9/skaffold
that referenced
this pull request
Jun 8, 2023
…ainerTools#8847) * fix: logic to interrupt a k8sjob logs as soon as it fails and change in delete order, now the job is deleted before its pods * test: integration tests to check when a log should not appear in the output (cherry picked from commit c7c72a1)
renzodavid9
added a commit
to renzodavid9/skaffold
that referenced
this pull request
Jun 8, 2023
…ainerTools#8847) * fix: logic to interrupt a k8sjob logs as soon as it fails and change in delete order, now the job is deleted before its pods * test: integration tests to check when a log should not appear in the output (cherry picked from commit c7c72a1)
renzodavid9
added a commit
to renzodavid9/skaffold
that referenced
this pull request
Jun 9, 2023
…ainerTools#8847) * fix: logic to interrupt a k8sjob logs as soon as it fails and change in delete order, now the job is deleted before its pods * test: integration tests to check when a log should not appear in the output (cherry picked from commit c7c72a1)
renzodavid9
added a commit
that referenced
this pull request
Jun 9, 2023
) * fix: logic to interrupt a k8sjob logs as soon as it fails and change in delete order, now the job is deleted before its pods * test: integration tests to check when a log should not appear in the output (cherry picked from commit c7c72a1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8839
Description
This PR adds the logic to interrupt the k8sjob custom actions log when a task fails, so we don't see the logs of a job that shouldn't be running. Also, the change in how we do the delete is changing: now we delete first the job and then its pod; before, we could have cases when we kill the pod, and before killing the job, it created a new pod.