fix: condition to not update helm deployer hook patches, is not needed#8862
Merged
Conversation
plumpy
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8854
Description
This PR changes the upgrade logic to not process the helm deployer hook patches, they should stay with the same path value from Skaffold v1 schema versions; currently when we detect a patch in a helm deployer hook we change it from
deploy/helm/hooks/...tomanifest/helm/hooks/..., the fieldmanifest/helm/hooks/...doesn't exist in Skaffold v2 schemas ( >= v3alpha1)