Skip to content

fix: #8870 manifest kustomize paths using env var with absolute path#8877

Merged
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
ryanohnemus:main
Jun 12, 2023
Merged

fix: #8870 manifest kustomize paths using env var with absolute path#8877
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
ryanohnemus:main

Conversation

@ryanohnemus

Copy link
Copy Markdown
Contributor

Fixes: #8870 manifest kustomize paths using env var with absolute path

Description
The absolute path expansion was happening before any environment template expansion occurred within the path variable. This caused kustomize paths that contain environment template variables using an absolute path to have the workspace path prepended which would then generate an invalid path that would be sent to the kustomize build command.

This change has environment variable expansion within kustomize paths occur before absolute path expansion.

@google-cla

google-cla Bot commented Jun 9, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ericzzzzzzz ericzzzzzzz self-assigned this Jun 12, 2023
@ericzzzzzzz ericzzzzzzz added the kokoro:run runs the kokoro jobs on a PR label Jun 12, 2023
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 12, 2023
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Jun 12, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 12, 2023
@ericzzzzzzz ericzzzzzzz merged commit 146d36b into GoogleContainerTools:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants