fix: Clean up dev images except the last#8897
Merged
ericzzzzzzz merged 7 commits intoJun 22, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8897 +/- ##
==========================================
- Coverage 70.48% 63.74% -6.74%
==========================================
Files 515 622 +107
Lines 23150 31598 +8448
==========================================
+ Hits 16317 20143 +3826
- Misses 5776 9943 +4167
- Partials 1057 1512 +455
... and 414 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
renzodavid9
reviewed
Jun 20, 2023
renzodavid9
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8545
Description
Test Plan
skaffold devthen modify some file to trigger a few rebuilds, check your built images withdocker image lsorminikube image lsif you're using minikube