Skip to content

fix: Clean up dev images except the last#8897

Merged
ericzzzzzzz merged 7 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:clean-up-dev-images-except-the-last
Jun 22, 2023
Merged

fix: Clean up dev images except the last#8897
ericzzzzzzz merged 7 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:clean-up-dev-images-except-the-last

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Fixes: #8545

Description

  • Clean up all images created during skaffold dev loop except the last one in local environment.

Test Plan

  • Run skaffold dev then modify some file to trigger a few rebuilds, check your built images with docker image ls or minikube image ls if you're using minikube
@codecov

codecov Bot commented Jun 16, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8897 (b761b13) into main (290280e) will decrease coverage by 6.74%.
The diff coverage is 48.99%.

@@            Coverage Diff             @@
##             main    #8897      +/-   ##
==========================================
- Coverage   70.48%   63.74%   -6.74%     
==========================================
  Files         515      622     +107     
  Lines       23150    31598    +8448     
==========================================
+ Hits        16317    20143    +3826     
- Misses       5776     9943    +4167     
- Partials     1057     1512     +455     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 414 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review June 19, 2023 14:00
@ericzzzzzzz ericzzzzzzz requested a review from renzodavid9 June 19, 2023 14:01
Comment thread pkg/skaffold/build/local/local.go
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Jun 21, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 21, 2023
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Jun 21, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 21, 2023
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Jun 21, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 21, 2023
@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Jun 21, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 21, 2023
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Jun 22, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 22, 2023
@ericzzzzzzz ericzzzzzzz merged commit 71dd5be into GoogleContainerTools:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants