chore: update the way the LTS images are built#8953
Conversation
|
FYI, proposing this on |
Codecov Report
@@ Coverage Diff @@
## release/v2.6 #8953 +/- ##
===============================================
Coverage ? 63.62%
===============================================
Files ? 624
Lines ? 31925
Branches ? 0
===============================================
Hits ? 20311
Misses ? 10087
Partials ? 1527 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ericzzzzzzz
left a comment
ericzzzzzzz
left a comment
There was a problem hiding this comment.
Maybe test it with a person project by connecting gcb with your fork ?
| args: | ||
| - 'build' | ||
| - '--cache-from' | ||
| - 'gcr.io/$PROJECT_ID/skaffold-builder:latest' |
There was a problem hiding this comment.
I think we need to add
- '--build-arg'
- 'SKAFFOLD_VERSION=$TAG_NAME'to inject version to the build context
There was a problem hiding this comment.
Ah, sorry, I was testing this with a modified version of this file (mostly because I didn't want to push to AR too) and then I forgot to copy my fixes back into this file. Fixed!
| - 'gcr.io/$PROJECT_ID/skaffold-builder:latest' | ||
| - 'gcr.io/$PROJECT_ID/skaffold:$_SCANNING_MARKER-lts' | ||
| - '-t' | ||
| - 'us-east1-docker.pkg.dev/$PROJECT_ID/scanning/skaffold:$TAG_NAME-lts' |
There was a problem hiding this comment.
This means, artifact registry scanner will scan all binary deps, probably we want to do it anyway. Just double check this is intended behavior?
There was a problem hiding this comment.
oh.. seems that our internal scanner is already doing this may be we don't need to push the image to ar anymore
There was a problem hiding this comment.
Okay, I removed AR. I wasn't sure why that was there but didn't want to change it...
I testing it by doing this: Do you think that's good enough or should I wire up a trigger? |
…8953) * chore: update the way the LTS images are built * Add the --build-arg and remove the Artifact Registry copy.
…8953) * chore: update the way the LTS images are built * Add the --build-arg and remove the Artifact Registry copy.
…8953) * chore: update the way the LTS images are built * Add the --build-arg and remove the Artifact Registry copy.
2 participants
I moved everything from
Dockerfile.deps.ltsintoDockerfile.ltsdirectly. Unforunately, this makes this diff pretty useless, but basically the only changes were thedownload-skaffoldsection at the top and the removal of the Go installation (the last two lines).