feat: support overrides in helm renderer#8966
Conversation
30be4ac to
6052ea6
Compare
Codecov Report
@@ Coverage Diff @@
## main #8966 +/- ##
==========================================
- Coverage 70.48% 63.63% -6.86%
==========================================
Files 515 624 +109
Lines 23150 31947 +8797
==========================================
+ Hits 16317 20329 +4012
- Misses 5776 10086 +4310
- Partials 1057 1532 +475
... and 415 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I'm not sure that failing integration test is related to the changes I made here. |
Hey @jackwilsdon, I triggered the tests again and they worked, so looks like we should be fine. Thanks for the PR! It looks good. I think we can add a new integration test that uses |
|
Tremendous! Thank you very much @jackwilsdon |
Fixes: #7687
Description
Adds support for the
manifests.helm.releases[].overridesfield. Previously this was only supported when using Helm as a deployer.The majority of this change is moving the body of the
range h.config.Releasesloop into a separate function so that thedeferis run after each release. Viewing the changes with whitespace hidden makes it a bit easier to read: https://github.com/GoogleContainerTools/skaffold/pull/8966/files?w=1