Skip to content

feat: support overrides in helm renderer#8966

Merged
renzodavid9 merged 1 commit into
GoogleContainerTools:mainfrom
jackwilsdon:helm-renderer-override-support
Aug 14, 2023
Merged

feat: support overrides in helm renderer#8966
renzodavid9 merged 1 commit into
GoogleContainerTools:mainfrom
jackwilsdon:helm-renderer-override-support

Conversation

@jackwilsdon

@jackwilsdon jackwilsdon commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Fixes: #7687

Description
Adds support for the manifests.helm.releases[].overrides field. Previously this was only supported when using Helm as a deployer.

The majority of this change is moving the body of the range h.config.Releases loop into a separate function so that the defer is run after each release. Viewing the changes with whitespace hidden makes it a bit easier to read: https://github.com/GoogleContainerTools/skaffold/pull/8966/files?w=1

@jackwilsdon jackwilsdon force-pushed the helm-renderer-override-support branch from 30be4ac to 6052ea6 Compare July 21, 2023 15:32
@codecov

codecov Bot commented Aug 14, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8966 (6052ea6) into main (290280e) will decrease coverage by 6.86%.
Report is 999 commits behind head on main.
The diff coverage is 48.91%.

@@            Coverage Diff             @@
##             main    #8966      +/-   ##
==========================================
- Coverage   70.48%   63.63%   -6.86%     
==========================================
  Files         515      624     +109     
  Lines       23150    31947    +8797     
==========================================
+ Hits        16317    20329    +4012     
- Misses       5776    10086    +4310     
- Partials     1057     1532     +475     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 415 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 added the kokoro:run runs the kokoro jobs on a PR label Aug 14, 2023
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Aug 14, 2023
@jackwilsdon

jackwilsdon commented Aug 14, 2023

Copy link
Copy Markdown
Contributor Author

I'm not sure that failing integration test is related to the changes I made here.

@renzodavid9

renzodavid9 commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

I'm not sure that failing integration test is related to the changes I made here.

Hey @jackwilsdon, I triggered the tests again and they worked, so looks like we should be fine.

Thanks for the PR! It looks good. I think we can add a new integration test that uses override with skaffold render later; I'll merge this and will create an issue to follow-up with the integration test. Thanks! 😄

@renzodavid9 renzodavid9 merged commit be8f9f4 into GoogleContainerTools:main Aug 14, 2023
@jackwilsdon jackwilsdon deleted the helm-renderer-override-support branch August 14, 2023 16:17
@mcg1969

mcg1969 commented Aug 14, 2023

Copy link
Copy Markdown

Tremendous! Thank you very much @jackwilsdon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants