Skip to content

fix: #9006 - Filter port forwarding resources for docker deploy#9008

Merged
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
jcscottiii:jcscottiii/fix-9006
Aug 14, 2023
Merged

fix: #9006 - Filter port forwarding resources for docker deploy#9008
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
jcscottiii:jcscottiii/fix-9006

Conversation

@jcscottiii

@jcscottiii jcscottiii commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

Fixes: #9006

Description

Add a filter function to only send port forwarding resources for that particular container into AllocatePort

Add a filter function to only send port resource resources for that particular container into AllocatePort
@jcscottiii jcscottiii force-pushed the jcscottiii/fix-9006 branch from 66aae6a to 223344b Compare August 10, 2023 15:20
portForwardResources: nil,
},
{
name: "two artifacts two bindings and two port forward resources",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially, I added a test case to the TestDebugBindings function since it was the only function here. However, I did end up adding a separate function TestFilterPortForwardingResources to test specifically that. Let me know if I should revert the changes in this TestDebugBindings function.

@jcscottiii jcscottiii changed the title Attempt fix at #9006 Aug 10, 2023
@ericzzzzzzz ericzzzzzzz added the kokoro:run runs the kokoro jobs on a PR label Aug 14, 2023
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Aug 14, 2023
@codecov

codecov Bot commented Aug 14, 2023

Copy link
Copy Markdown

Codecov Report

Merging #9008 (223344b) into main (290280e) will decrease coverage by 6.85%.
Report is 997 commits behind head on main.
The diff coverage is 49.80%.

@@            Coverage Diff             @@
##             main    #9008      +/-   ##
==========================================
- Coverage   70.48%   63.64%   -6.85%     
==========================================
  Files         515      624     +109     
  Lines       23150    31933    +8783     
==========================================
+ Hits        16317    20323    +4006     
- Misses       5776    10081    +4305     
- Partials     1057     1529     +472     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 415 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz enabled auto-merge (squash) August 14, 2023 12:13
@ericzzzzzzz ericzzzzzzz merged commit 59a928e into GoogleContainerTools:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants