fix: #9006 - Filter port forwarding resources for docker deploy#9008
Merged
ericzzzzzzz merged 1 commit intoAug 14, 2023
Merged
Conversation
Add a filter function to only send port resource resources for that particular container into AllocatePort
66aae6a to
223344b
Compare
jcscottiii
commented
Aug 10, 2023
| portForwardResources: nil, | ||
| }, | ||
| { | ||
| name: "two artifacts two bindings and two port forward resources", |
Contributor
Author
There was a problem hiding this comment.
Initially, I added a test case to the TestDebugBindings function since it was the only function here. However, I did end up adding a separate function TestFilterPortForwardingResources to test specifically that. Let me know if I should revert the changes in this TestDebugBindings function.
Codecov Report
@@ Coverage Diff @@
## main #9008 +/- ##
==========================================
- Coverage 70.48% 63.64% -6.85%
==========================================
Files 515 624 +109
Lines 23150 31933 +8783
==========================================
+ Hits 16317 20323 +4006
- Misses 5776 10081 +4305
- Partials 1057 1529 +472
... and 415 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ericzzzzzzz
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9006
Description
Add a filter function to only send port forwarding resources for that particular container into AllocatePort