Skip to content

feat: support url as kustomize file path#9023

Merged
ericzzzzzzz merged 4 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:support-abs-url-as-kustomize-path
Aug 17, 2023
Merged

feat: support url as kustomize file path#9023
ericzzzzzzz merged 4 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:support-abs-url-as-kustomize-path

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Fixes: #8940

Description

  • add support for kustomize remote manifests.
@codecov

codecov Bot commented Aug 16, 2023

Copy link
Copy Markdown

Codecov Report

Merging #9023 (2ba5a6e) into main (290280e) will decrease coverage by 6.85%.
Report is 1003 commits behind head on main.
The diff coverage is 49.90%.

@@            Coverage Diff             @@
##             main    #9023      +/-   ##
==========================================
- Coverage   70.48%   63.63%   -6.85%     
==========================================
  Files         515      624     +109     
  Lines       23150    31944    +8794     
==========================================
+ Hits        16317    20328    +4011     
- Misses       5776    10084    +4308     
- Partials     1057     1532     +475     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 416 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz force-pushed the support-abs-url-as-kustomize-path branch from 756aa77 to f75f448 Compare August 16, 2023 13:12
@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review August 16, 2023 13:13
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Aug 16, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Aug 16, 2023
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Aug 16, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Aug 16, 2023
@ericzzzzzzz ericzzzzzzz merged commit a146043 into GoogleContainerTools:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants