Skip to content

fix: verify flaky tests#9050

Merged
ericzzzzzzz merged 4 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:fix-verify-flaky-tests
Aug 29, 2023
Merged

fix: verify flaky tests#9050
ericzzzzzzz merged 4 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:fix-verify-flaky-tests

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

Description

  • We've been seeing some verify and custom actions related flaky tests on Kokoro tests
  • The cause is that some integration tests contaminate each other, and this is more likely to happen on gcp tests, as we're running tests against shared remote clusters concurrently-- 4 worker nodes running tests against one shared remote cluster, adding namespace for integration tests should provide the isolation but namespace flag is not added in verify and exec command. enable namespace flag for command verify and exec #9051
  • Github CI should provide better isolation , each worker runs tests against its dedicated minikube -- not 100% sure , but we should also isolate these tests by providing unique names as job names so when skaffold run query to watch resources it can watch the correct resource.
@ericzzzzzzz ericzzzzzzz changed the title Fix verify flaky tests Aug 28, 2023
@codecov

codecov Bot commented Aug 28, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.47%. Comparing base (290280e) to head (4ed037e).
⚠️ Report is 1426 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9050      +/-   ##
==========================================
- Coverage   70.48%   63.47%   -7.01%     
==========================================
  Files         515      624     +109     
  Lines       23150    32024    +8874     
==========================================
+ Hits        16317    20327    +4010     
- Misses       5776    10162    +4386     
- Partials     1057     1535     +478     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Aug 28, 2023
@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review August 28, 2023 20:04
@ericzzzzzzz ericzzzzzzz merged commit a66f3fa into GoogleContainerTools:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants