Skip to content

feat: Add skaffold inspect command for adding config dependencies#9072

Merged
renzodavid9 merged 10 commits into
GoogleContainerTools:mainfrom
mattsanta:add
Sep 12, 2023
Merged

feat: Add skaffold inspect command for adding config dependencies#9072
renzodavid9 merged 10 commits into
GoogleContainerTools:mainfrom
mattsanta:add

Conversation

@mattsanta

Copy link
Copy Markdown
Contributor

Related: #9071

Description
Introduces the ability to add config dependencies to configs defined in a skaffold file. This command works similar to the skaffold inspect build-env commands that can be used to manipulate skaffold config(s).

User facing changes (remove if N/A)
Similar to the other inspect commands this is hidden but obviously can be used if a user is aware of it.

@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Sep 6, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Sep 6, 2023
@codecov

codecov Bot commented Sep 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #9072 (21485a8) into main (290280e) will decrease coverage by 7.08%.
Report is 1024 commits behind head on main.
The diff coverage is 48.90%.

@@            Coverage Diff             @@
##             main    #9072      +/-   ##
==========================================
- Coverage   70.48%   63.40%   -7.08%     
==========================================
  Files         515      628     +113     
  Lines       23150    32267    +9117     
==========================================
+ Hits        16317    20459    +4142     
- Misses       5776    10246    +4470     
- Partials     1057     1562     +505     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <0.00%> (ø)
... and 41 more

... and 432 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread pkg/skaffold/inspect/configDependencies/add.go Outdated
@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Sep 10, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Sep 10, 2023
@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Sep 11, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Sep 11, 2023

@renzodavid9 renzodavid9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@renzodavid9 renzodavid9 merged commit 45169d9 into GoogleContainerTools:main Sep 12, 2023
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants