Skip to content

feat: inject namespace from rendered manifests in post deploy hooks#9090

Merged
renzodavid9 merged 3 commits into
GoogleContainerTools:mainfrom
renzodavid9:issue-8357-deploy-hooks
Sep 15, 2023
Merged

feat: inject namespace from rendered manifests in post deploy hooks#9090
renzodavid9 merged 3 commits into
GoogleContainerTools:mainfrom
renzodavid9:issue-8357-deploy-hooks

Conversation

@renzodavid9

@renzodavid9 renzodavid9 commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Fixes: #8357

Description
This PR adds the logic to inject the namespaces from the rendered manifests into the post deploy hooks. The manifests namespaces are assigned every time a new deployment happens.

Follow-up Work
Check this behaviour for the Sync hooks which use the same namespaces env variable

@codecov

codecov Bot commented Sep 14, 2023

Copy link
Copy Markdown

Codecov Report

Merging #9090 (61d4e26) into main (290280e) will decrease coverage by 7.07%.
Report is 1028 commits behind head on main.
The diff coverage is 48.90%.

@@            Coverage Diff             @@
##             main    #9090      +/-   ##
==========================================
- Coverage   70.48%   63.42%   -7.07%     
==========================================
  Files         515      628     +113     
  Lines       23150    32294    +9144     
==========================================
+ Hits        16317    20482    +4165     
- Misses       5776    10251    +4475     
- Partials     1057     1561     +504     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <0.00%> (ø)
... and 41 more

... and 432 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 force-pushed the issue-8357-deploy-hooks branch from 51097a3 to 61d4e26 Compare September 14, 2023 18:16
@renzodavid9 renzodavid9 marked this pull request as ready for review September 15, 2023 11:05
@renzodavid9 renzodavid9 merged commit 1c3944b into GoogleContainerTools:main Sep 15, 2023
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants