feat: inject namespace from rendered manifests in post deploy hooks#9090
Merged
renzodavid9 merged 3 commits intoSep 15, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9090 +/- ##
==========================================
- Coverage 70.48% 63.42% -7.07%
==========================================
Files 515 628 +113
Lines 23150 32294 +9144
==========================================
+ Hits 16317 20482 +4165
- Misses 5776 10251 +4475
- Partials 1057 1561 +504
... and 432 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
51097a3 to
61d4e26
Compare
ericzzzzzzz
approved these changes
Sep 15, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8357
Description
This PR adds the logic to inject the namespaces from the rendered manifests into the post deploy hooks. The manifests namespaces are assigned every time a new deployment happens.
Follow-up Work
Check this behaviour for the Sync hooks which use the same namespaces env variable