Skip to content

chore: bump schema version to v4beta8#9143

Merged
renzodavid9 merged 2 commits into
GoogleContainerTools:mainfrom
renzodavid9:v4beta8-schema-upgrade
Oct 23, 2023
Merged

chore: bump schema version to v4beta8#9143
renzodavid9 merged 2 commits into
GoogleContainerTools:mainfrom
renzodavid9:v4beta8-schema-upgrade

Conversation

@renzodavid9

@renzodavid9 renzodavid9 commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

Related: #9139

Description
Upgrade schema to v4beta8 needed for #9139.

All the files in this PR were auto generated from running hack/new-version.sh (following the schema change guide) except for the change in the pinned version for builder images in examples/dev-journey-buildpacks/skaffold.yaml and integration/examples/dev-journey-buildpacks/skaffold.yaml; there was a test reporting a problem running the example, the builder image itself was reporting a problem, was an old image.

@codecov

codecov Bot commented Oct 20, 2023

Copy link
Copy Markdown

Codecov Report

Merging #9143 (137107c) into main (290280e) will decrease coverage by 7.13%.
Report is 1045 commits behind head on main.
The diff coverage is 48.33%.

@@            Coverage Diff             @@
##             main    #9143      +/-   ##
==========================================
- Coverage   70.48%   63.35%   -7.13%     
==========================================
  Files         515      630     +115     
  Lines       23150    32413    +9263     
==========================================
+ Hits        16317    20535    +4218     
- Misses       5776    10312    +4536     
- Partials     1057     1566     +509     
Files Coverage Δ
cmd/skaffold/app/cmd/commands.go 97.61% <100.00%> (+0.35%) ⬆️
cmd/skaffold/app/cmd/config.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/flags.go 93.00% <100.00%> (+2.18%) ⬆️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/init.go 100.00% <100.00%> (ø)
... and 41 more

... and 433 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 marked this pull request as ready for review October 23, 2023 14:14
@renzodavid9 renzodavid9 requested a review from a team as a code owner October 23, 2023 14:14

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@renzodavid9 renzodavid9 merged commit ccb09a7 into GoogleContainerTools:main Oct 23, 2023
@renzodavid9 renzodavid9 deleted the v4beta8-schema-upgrade branch October 23, 2023 16:24
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants