chore: change custom actions pull logic, to check if an image exists locally first before triggering a pull#9147
Merged
renzodavid9 merged 4 commits intoOct 24, 2023
Conversation
… running a local custom action
Codecov Report
@@ Coverage Diff @@
## main #9147 +/- ##
==========================================
- Coverage 70.48% 63.35% -7.13%
==========================================
Files 515 630 +115
Lines 23150 32419 +9269
==========================================
+ Hits 16317 20540 +4223
- Misses 5776 10314 +4538
- Partials 1057 1565 +508
... and 434 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
… to check or not the local daemon before pull
4d30132 to
183fcba
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9139
Description
This PR adds a new config field for local custom actions to force the use of a local image if one exists, if it doesn't exists it will trigger a pull.
How to test the change
With the following
skaffold.yamlfile:Execute
skaffold exec my-action. You'll notice that the image is pull from the registry before running the container. Now if you runskaffold exec my-actionagain, you'll see that Skaffold is not trying to pull the image again from the registry.Follow-up work
#9148: We'll be adding the same logic for
skaffold verify, the schema change affects both,customActions, andverify.