chore: add new skip-unreachable-dirs to not error on init command when a dir can not be read#9163
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9163 +/- ##
==========================================
- Coverage 70.48% 63.68% -6.80%
==========================================
Files 515 630 +115
Lines 23150 32435 +9285
==========================================
+ Hits 16317 20657 +4340
- Misses 5776 10189 +4413
- Partials 1057 1589 +532
... and 434 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
27beaa1 to
fecadca
Compare
ericzzzzzzz
approved these changes
Nov 7, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9164
Description
This PR adds a new flag,
--skip-unreachable-dirsto change the behaviour ofskaffold initcommand so it doesn't throw an error when it tries to read a folder for which it doesn't have read permissions, instead it will skip the folder and continue with the initialization.Test
To test it, using the same repro steps from #9164, now running
skaffold init --analyze --skip-unreachable-dirsshouldn't return an error.