Skip to content

fix: sync slow#9167

Merged
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
ericzzzzzzz:fix-sync-slow
Nov 8, 2023
Merged

fix: sync slow#9167
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
ericzzzzzzz:fix-sync-slow

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

Fixes: #8166

#8249 fixed #8166, #9029 accidentally removed skipDir logic which caused the regression, this pr added corresponding logic back.
Test plan is in #8249

@codecov

codecov Bot commented Nov 8, 2023

Copy link
Copy Markdown

Codecov Report

Merging #9167 (0ec203e) into main (290280e) will decrease coverage by 6.76%.
Report is 1064 commits behind head on main.
The diff coverage is 48.51%.

@@            Coverage Diff             @@
##             main    #9167      +/-   ##
==========================================
- Coverage   70.48%   63.72%   -6.76%     
==========================================
  Files         515      630     +115     
  Lines       23150    32447    +9297     
==========================================
+ Hits        16317    20678    +4361     
- Misses       5776    10183    +4407     
- Partials     1057     1586     +529     
Files Coverage Δ
cmd/skaffold/app/cmd/commands.go 97.61% <100.00%> (+0.35%) ⬆️
cmd/skaffold/app/cmd/config.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/flags.go 93.00% <100.00%> (+2.18%) ⬆️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/init.go 100.00% <100.00%> (ø)
... and 41 more

... and 433 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@ericzzzzzzz ericzzzzzzz merged commit e880f5a into GoogleContainerTools:main Nov 8, 2023
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants