docs: Add missing template field#9186
Merged
renzodavid9 merged 1 commit intoNov 22, 2023
Merged
Conversation
Templates work for manifests, too. So document `setValueTemplates` since we are actually using it.
c6eb4d7 to
f999ef1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9186 +/- ##
==========================================
- Coverage 70.48% 63.72% -6.76%
==========================================
Files 515 630 +115
Lines 23150 32447 +9297
==========================================
+ Hits 16317 20678 +4361
- Misses 5776 10179 +4403
- Partials 1057 1590 +533 ☔ View full report in Codecov by Sentry. |
renzodavid9
approved these changes
Nov 22, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Templates work for manifests, too.
So document
setValueTemplatessince we are actually using it.User facing changes
Documentation is less incomplete.
Follow-up Work
From the looks of it, there might be more fields missing.