Skip to content

chore: generate schema v4beta9#9204

Merged
renzodavid9 merged 1 commit into
GoogleContainerTools:mainfrom
ericzzzzzzz:new-schema-for-post-renderer
Dec 5, 2023
Merged

chore: generate schema v4beta9#9204
renzodavid9 merged 1 commit into
GoogleContainerTools:mainfrom
ericzzzzzzz:new-schema-for-post-renderer

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Dec 4, 2023

Copy link
Copy Markdown
Contributor
  • add a new schema to support skaffold post-renderer that support making changes on render result
  • We will need a flag to let users indicate if the output from post render hooks should be parsed by skaffold as the updated rendered result(k8s resource manifest).
@codecov

codecov Bot commented Dec 4, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 295 lines in your changes are missing coverage. Please review.

Comparison is base (290280e) 70.48% compared to head (a7cbe24) 63.64%.
Report is 1072 commits behind head on main.

Files Patch % Lines
cmd/skaffold/app/cmd/exec.go 16.32% 40 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/filter.go 47.27% 22 Missing and 7 partials ⚠️
cmd/skaffold/app/cmd/lsp.go 28.12% 23 Missing ⚠️
cmd/skaffold/app/cmd/verify.go 23.33% 23 Missing ⚠️
cmd/skaffold/app/cmd/fix.go 51.16% 17 Missing and 4 partials ⚠️
cmd/skaffold/app/cmd/inspect_job_manifest_paths.go 60.00% 15 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/inspect_namespaces.go 50.00% 13 Missing and 1 partial ⚠️
...md/skaffold/app/cmd/inspect_config_dependencies.go 45.83% 12 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/lint.go 42.85% 12 Missing ⚠️
cmd/skaffold/app/cmd/inspect_build_env.go 60.71% 11 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9204      +/-   ##
==========================================
- Coverage   70.48%   63.64%   -6.84%     
==========================================
  Files         515      632     +117     
  Lines       23150    32546    +9396     
==========================================
+ Hits        16317    20714    +4397     
- Misses       5776    10238    +4462     
- Partials     1057     1594     +537     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review December 5, 2023 16:55
@ericzzzzzzz ericzzzzzzz requested a review from a team as a code owner December 5, 2023 16:55
@renzodavid9 renzodavid9 merged commit da91f85 into GoogleContainerTools:main Dec 5, 2023
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants