Skip to content

fix: apply-setter and transformer should ignore non-k8s-resource for kustomize paramterization#9240

Merged
ericzzzzzzz merged 2 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:skip-apply-setter-and-transformer-for-non-k8s-resource
Jan 8, 2024
Merged

fix: apply-setter and transformer should ignore non-k8s-resource for kustomize paramterization#9240
ericzzzzzzz merged 2 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:skip-apply-setter-and-transformer-for-non-k8s-resource

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Jan 7, 2024

Copy link
Copy Markdown
Contributor

Fixes: #9239

  • kustomize parameterization doesn't work when having dependent files that are not k8s resources as apply-setters and other krm functions should only be applied to k8s resources, hence skipping applying those functions when mirroring kustomization files
@codecov

codecov Bot commented Jan 7, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 295 lines in your changes are missing coverage. Please review.

Comparison is base (290280e) 70.48% compared to head (48c42a5) 63.62%.
Report is 1087 commits behind head on main.

Files Patch % Lines
cmd/skaffold/app/cmd/exec.go 16.32% 40 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/filter.go 47.27% 22 Missing and 7 partials ⚠️
cmd/skaffold/app/cmd/lsp.go 28.12% 23 Missing ⚠️
cmd/skaffold/app/cmd/verify.go 23.33% 23 Missing ⚠️
cmd/skaffold/app/cmd/fix.go 51.16% 17 Missing and 4 partials ⚠️
cmd/skaffold/app/cmd/inspect_job_manifest_paths.go 60.00% 15 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/inspect_namespaces.go 50.00% 13 Missing and 1 partial ⚠️
...md/skaffold/app/cmd/inspect_config_dependencies.go 45.83% 12 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/lint.go 42.85% 12 Missing ⚠️
cmd/skaffold/app/cmd/inspect_build_env.go 60.71% 11 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9240      +/-   ##
==========================================
- Coverage   70.48%   63.62%   -6.86%     
==========================================
  Files         515      632     +117     
  Lines       23150    32600    +9450     
==========================================
+ Hits        16317    20743    +4426     
- Misses       5776    10259    +4483     
- Partials     1057     1598     +541     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review January 8, 2024 15:11
@ericzzzzzzz ericzzzzzzz merged commit ccb8c6e into GoogleContainerTools:main Jan 8, 2024
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants