feat: extracted kaniko copyTimeout and copyMaxRetries into config#9267
Merged
ericzzzzzzz merged 7 commits intoJan 31, 2024
Merged
Conversation
Contributor
Author
|
Hi! |
Contributor
Author
|
@MarlonGamez , hi! Could you please review the PR? The size is big because of generated files(2 new config keys for kaniko), the changes themselves aren't that big. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9267 +/- ##
==========================================
- Coverage 70.48% 63.55% -6.94%
==========================================
Files 515 634 +119
Lines 23150 32721 +9571
==========================================
+ Hits 16317 20795 +4478
- Misses 5776 10322 +4546
- Partials 1057 1604 +547 ☔ View full report in Codecov by Sentry. |
ericzzzzzzz
approved these changes
Jan 31, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I use skaffold for big project and sometimes it takes more than 5 minutes to create tar(it tries to add more than 80k files) and fails because of timeout, but 5m was hardcoded so I decided to extract it to config.
Changes previews
