Skip to content

fix(lookupRemote): fixed lookup.go lookupRemote to compare remote and cached digests#9278

Merged
ericzzzzzzz merged 5 commits into
GoogleContainerTools:mainfrom
idsulik:fix-issue-9248
Jan 31, 2024
Merged

fix(lookupRemote): fixed lookup.go lookupRemote to compare remote and cached digests#9278
ericzzzzzzz merged 5 commits into
GoogleContainerTools:mainfrom
idsulik:fix-issue-9248

Conversation

@idsulik

@idsulik idsulik commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

Fixes: #9248

Description
It is used to lookup remote images by tag and overwrite a cached item even if the digests are different, now it compares the digests

@idsulik idsulik marked this pull request as draft January 26, 2024 08:01
@idsulik idsulik marked this pull request as ready for review January 29, 2024 08:33
@ericzzzzzzz ericzzzzzzz added the kokoro:run runs the kokoro jobs on a PR label Jan 31, 2024
@codecov

codecov Bot commented Jan 31, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 295 lines in your changes are missing coverage. Please review.

Comparison is base (290280e) 70.48% compared to head (2974b9c) 63.56%.
Report is 1104 commits behind head on main.

Files Patch % Lines
cmd/skaffold/app/cmd/exec.go 16.32% 40 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/filter.go 47.27% 22 Missing and 7 partials ⚠️
cmd/skaffold/app/cmd/lsp.go 28.12% 23 Missing ⚠️
cmd/skaffold/app/cmd/verify.go 23.33% 23 Missing ⚠️
cmd/skaffold/app/cmd/fix.go 51.16% 17 Missing and 4 partials ⚠️
cmd/skaffold/app/cmd/inspect_job_manifest_paths.go 60.00% 15 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/inspect_namespaces.go 50.00% 13 Missing and 1 partial ⚠️
...md/skaffold/app/cmd/inspect_config_dependencies.go 45.83% 12 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/lint.go 42.85% 12 Missing ⚠️
cmd/skaffold/app/cmd/inspect_build_env.go 60.71% 11 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9278      +/-   ##
==========================================
- Coverage   70.48%   63.56%   -6.92%     
==========================================
  Files         515      634     +119     
  Lines       23150    32717    +9567     
==========================================
+ Hits        16317    20798    +4481     
- Misses       5776    10316    +4540     
- Partials     1057     1603     +546     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 31, 2024
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Jan 31, 2024
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jan 31, 2024
@ericzzzzzzz ericzzzzzzz merged commit 9ff4546 into GoogleContainerTools:main Jan 31, 2024
@bhack

bhack commented Jan 31, 2024

Copy link
Copy Markdown

Do you plan a patch release?

ericzzzzzzz pushed a commit to ericzzzzzzz/skaffold that referenced this pull request Feb 7, 2024
… cached digests (GoogleContainerTools#9278)

* fix(lookupRemote): fixed lookup.go lookupRemote to compare remote and cached digests

* fixes

* fixed lookup.go

* fixes
@ericzzzzzzz

Copy link
Copy Markdown
Contributor

#9301 to patch on 2.10

ericzzzzzzz added a commit that referenced this pull request Feb 7, 2024
* fix(lookupRemote): fixed lookup.go lookupRemote to compare remote and cached digests (#9278)

* fix(lookupRemote): fixed lookup.go lookupRemote to compare remote and cached digests

* fixes

* fixed lookup.go

* fixes

* feat: schema

* lint

---------

Co-authored-by: idsulik <3595194+idsulik@users.noreply.github.com>
@noorul

noorul commented Feb 14, 2024

Copy link
Copy Markdown

I still see this issue in 2.10.1

@idsulik

idsulik commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

Yes, sorry, I fixed it here #9306 , waiting for merge

ericzzzzzzz added a commit to ericzzzzzzz/skaffold that referenced this pull request Feb 15, 2024
ericzzzzzzz added a commit that referenced this pull request Feb 15, 2024
* Revert "fix(lookupRemote): fixed lookup.go lookupRemote to compare remote and cached digests (#9278)"

This reverts commit 9ff4546.

* Revert "fix: Scope Issue with the 'entry' variable when looking up remote images and tests additions (#9211)"

This reverts commit ffe769c.

* Revert "fix: puling images when working with a remote repository (#9177) (#9181)"

This reverts commit 9376dc0.
@idsulik idsulik deleted the fix-issue-9248 branch July 22, 2024 07:15
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants