Skip to content

fix(helm): use secrets helm plugin to render when useHelmSecrets is true#9295

Merged
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
idsulik:fix-issue-7651
Feb 6, 2024
Merged

fix(helm): use secrets helm plugin to render when useHelmSecrets is true#9295
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
idsulik:fix-issue-7651

Conversation

@idsulik

@idsulik idsulik commented Feb 4, 2024

Copy link
Copy Markdown
Contributor

Fixes: #7651 and possibly #9119

Description
skaffold render used to ignore useHelmSecrets flag

User facing changes
Before: skaffold render didn't use helm secrets plugin
After: skaffold render uses helm secrets plugin

@codecov

codecov Bot commented Feb 4, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 295 lines in your changes are missing coverage. Please review.

Comparison is base (290280e) 70.48% compared to head (b3a7ef9) 63.60%.
Report is 1108 commits behind head on main.

Files Patch % Lines
cmd/skaffold/app/cmd/exec.go 16.32% 40 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/filter.go 47.27% 22 Missing and 7 partials ⚠️
cmd/skaffold/app/cmd/lsp.go 28.12% 23 Missing ⚠️
cmd/skaffold/app/cmd/verify.go 23.33% 23 Missing ⚠️
cmd/skaffold/app/cmd/fix.go 51.16% 17 Missing and 4 partials ⚠️
cmd/skaffold/app/cmd/inspect_job_manifest_paths.go 60.00% 15 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/inspect_namespaces.go 50.00% 13 Missing and 1 partial ⚠️
...md/skaffold/app/cmd/inspect_config_dependencies.go 45.83% 12 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/lint.go 42.85% 12 Missing ⚠️
cmd/skaffold/app/cmd/inspect_build_env.go 60.71% 11 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9295      +/-   ##
==========================================
- Coverage   70.48%   63.60%   -6.89%     
==========================================
  Files         515      635     +120     
  Lines       23150    32773    +9623     
==========================================
+ Hits        16317    20844    +4527     
- Misses       5776    10325    +4549     
- Partials     1057     1604     +547     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Feb 5, 2024
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Feb 5, 2024
@ericzzzzzzz

Copy link
Copy Markdown
Contributor

thank you for the fix!

@ericzzzzzzz ericzzzzzzz merged commit 7e79f94 into GoogleContainerTools:main Feb 6, 2024
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants