fix: retry on errors when watching pods#9373
Merged
plumpy merged 7 commits intoJan 14, 2025
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
If timeout (or some network error?) occurs while waiting for a pod initialization or termination event, e.g. when build takes a long time, skaffold becomes stuck and never finishes the operation. Use retry watcher to handle the errors gracefully.
mikedld
force-pushed
the
bugfix/gh8658-pod-wait-misses-events-after-timeout
branch
from
6f3b074 to
e1ec0c5
Compare
|
How can we encourage this fix to be merged? This issue is causing significant issues for skaffold users who want to utilize kaniko. |
Contributor
|
@mikedld Thank you for this PR. Would you mind fixing the conflicting files and that the PR is synced to skaffold main? |
alphanota
previously approved these changes
Jan 7, 2025
alphanota
approved these changes
Jan 14, 2025
alphanota
approved these changes
Jan 14, 2025
plumpy
approved these changes
Jan 14, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8658
Description
If timeout (or some network error) occurs while waiting for a pod initialization or termination event, e.g. when build takes a long time, skaffold becomes stuck and never finishes the operation. Use retry watcher to handle the errors gracefully.
This PR is based on the patch I posted in #8658 last year; never got any feedback on it there so decided to go ahead. I'm using this patch since then and it works fine on my end. To reiterate,
I only managed to fix exising unit test, not add any new test(s), as I'm not at all comfortable with Go. If that's an issue, I'm okay with someone else picking this up.