fix: TestGenerateMavenBuildArgs-host-platform#9410
Merged
ericzzzzzzz merged 2 commits intoMay 3, 2024
Merged
Conversation
ericzzzzzzz
commented
May 3, 2024
ericzzzzzzz
commented
Contributor
- This pr fixes TestGenerateMavenBuildArgs_host_platform, this test was failing due to github ci started using arm machine. So the defaultPlatformSpec contains Variant -- "v8" in the ci run, the test now uses platform.Format method to format defaultPlatformSpec instead of 'runtime.OS/runtime.platform', so when we run tests in an arm machine, platform.Format method will give us "OS/Arch/Variant"
renzodavid9
approved these changes
May 3, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.