Skip to content

chore: remove unused taggers field#9513

Merged
plumpy merged 1 commit into
GoogleContainerTools:mainfrom
cuishuang:main
Nov 11, 2024
Merged

chore: remove unused taggers field#9513
plumpy merged 1 commit into
GoogleContainerTools:mainfrom
cuishuang:main

Conversation

@cuishuang

@cuishuang cuishuang commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

remove no-used taggers field

@plumpy plumpy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I was wondering why this wasn't a problem before, and it looks like it's because the taggers field is never actually used. Can you just delete it instead?

Thanks for the PR!

@conventional-commit-lint-gcf

conventional-commit-lint-gcf Bot commented Nov 9, 2024

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@cuishuang

Copy link
Copy Markdown
Contributor Author

Interesting, I was wondering why this wasn't a problem before, and it looks like it's because the taggers field is never actually used. Can you just delete it instead?

Thanks for the PR!

Of course. Please review again.

@cuishuang cuishuang changed the title bug: fix slice init length Nov 9, 2024
Comment thread pkg/skaffold/tag/tagger_mux.go
Signed-off-by: cuishuang <imcusg@gmail.com>
@cuishuang cuishuang changed the title remove no-used taggers field Nov 11, 2024
@plumpy plumpy changed the title refactor: remove no-used taggers field Nov 11, 2024
@plumpy plumpy merged commit 264e274 into GoogleContainerTools:main Nov 11, 2024
@plumpy

plumpy commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

Thanks for sending the PR, we appreciate it!

@cuishuang

Copy link
Copy Markdown
Contributor Author

Thanks for sending the PR, we appreciate it!

I am very happy to do this.

plumpy added a commit to plumpy/skaffold that referenced this pull request Nov 20, 2024
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants