Support TemplateField for build.artifacts.docker.cliFlags#9582
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| if err != nil { | ||
| return "", fmt.Errorf("unable to evaluate build args: %w", err) | ||
| } | ||
| for i, cliFlag := range a.CliFlags { |
There was a problem hiding this comment.
Is this something that can be moved to where the other cli args are built: https://github.com/GoogleContainerTools/skaffold/blob/main/pkg/skaffold/docker/image.go#L629? I believe that would also add support for the GCB case.
There was a problem hiding this comment.
Sorry for the late reply. I fixed it!
ec0b09c to
3730f8c
Compare
3730f8c to
fa93f3e
Compare
|
Are there any plans to release a new version? |
Fixes: #9581
Description
Upon installing Docker Buildx, the docker build command becomes an alias for docker buildx build. This means that any subsequent docker build commands will be executed using the more advanced features provided by Buildx. Specifically, we intend to leverage the
--cache-to=type=registry,ref=repo/image:tagflag within these commands. In order to several registry, I want to TemplateField for build.artifacts.docker.cliFlags as following.User facing changes (remove if N/A)
User can use TemplateField in cliFlags.