chore: remove GRPC package excludes#9659
Conversation
ghost
left a comment
There was a problem hiding this comment.
Hi @plumpy, reviewers, and future viewers!
I'm currently reviewing this pull request, and will post a full review in a few minutes. In the meantime, here's a quick summary for everyone to get up to speed:
This PR removes some unnecessary GRPC package excludes from the go.mod file and upgrades all packages.
Intent:
The PR aims to simplify the project's dependency management by removing outdated package excludes and updating to the latest versions of all dependencies.
Changes:
I observed the following changes in this pull request:
- The
go.modfile has been modified to remove severalexcludedirectives related to thegoogle.golang.org/grpcpackage (lines 11-18 in the diff). - Several dependency versions have been updated in the
go.modfile (lines 28-165 in the diff). - The
go.sumfile has been updated to reflect the changes in dependency versions (lines 6-972 in the diff). - The
vendordirectory contains updates to various dependency packages, reflecting the version changes.
Activity:
The PR description mentions that the GRPC excludes were unnecessary and that all packages were upgraded after removing the excludes. No other activity is visible in the PR itself.
Here's a little haiku to lighten the mood:
Dependencies flow,
Old excludes now disappear,
Codebase refreshed.
Let me know if you have any questions!
ghost
left a comment
There was a problem hiding this comment.
This change removes the GRPC package excludes which were previously added as a workaround for an issue with the GCP Storage library. It also upgrades several packages. Removing the excludes is a good move now that the underlying issue is resolved. Upgrading packages regularly is also good practice for security and bug fixes. Ensure that tests pass with the upgraded packages, and pay attention to any breaking changes introduced by the upgrades.
These are now unnecessary.
Then, once again, upgrade all the packages.