Skip to content

chore: remove GRPC package excludes#9659

Merged
plumpy merged 4 commits into
GoogleContainerTools:mainfrom
plumpy:remove_grpc_excludes
Jan 14, 2025
Merged

chore: remove GRPC package excludes#9659
plumpy merged 4 commits into
GoogleContainerTools:mainfrom
plumpy:remove_grpc_excludes

Conversation

@plumpy

@plumpy plumpy commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

These are now unnecessary.

Then, once again, upgrade all the packages.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @plumpy, reviewers, and future viewers!

I'm currently reviewing this pull request, and will post a full review in a few minutes. In the meantime, here's a quick summary for everyone to get up to speed:

This PR removes some unnecessary GRPC package excludes from the go.mod file and upgrades all packages.

Intent:
The PR aims to simplify the project's dependency management by removing outdated package excludes and updating to the latest versions of all dependencies.

Changes:
I observed the following changes in this pull request:

  • The go.mod file has been modified to remove several exclude directives related to the google.golang.org/grpc package (lines 11-18 in the diff).
  • Several dependency versions have been updated in the go.mod file (lines 28-165 in the diff).
  • The go.sum file has been updated to reflect the changes in dependency versions (lines 6-972 in the diff).
  • The vendor directory contains updates to various dependency packages, reflecting the version changes.

Activity:
The PR description mentions that the GRPC excludes were unnecessary and that all packages were upgraded after removing the excludes. No other activity is visible in the PR itself.


Here's a little haiku to lighten the mood:

Dependencies flow,
Old excludes now disappear,
Codebase refreshed.

Let me know if you have any questions!

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes the GRPC package excludes which were previously added as a workaround for an issue with the GCP Storage library. It also upgrades several packages. Removing the excludes is a good move now that the underlying issue is resolved. Upgrading packages regularly is also good practice for security and bug fixes. Ensure that tests pass with the upgraded packages, and pay attention to any breaking changes introduced by the upgrades.

@plumpy plumpy marked this pull request as ready for review January 14, 2025 18:17
@plumpy plumpy requested a review from a team as a code owner January 14, 2025 18:17
@plumpy plumpy merged commit 4c6bfe5 into GoogleContainerTools:main Jan 14, 2025
@plumpy plumpy deleted the remove_grpc_excludes branch January 14, 2025 18:57
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants