chore: final cleanups of the go.mod file#9663
Conversation
ghost
left a comment
There was a problem hiding this comment.
Hi @plumpy, @reviewers,
I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary of the changes for you and other reviewers to get up to speed:
This pull request, "chore: final cleanups of the go.mod file", aims to perform some final cleanups on the go.mod file. The changes include:
- Removing an outdated exclude: The line
exclude github.com/karrick/godirwalk v1.17.0has been removed fromgo.mod. - Moving and pinning dependencies: Two dependencies have been moved to new paths. The old paths are pinned to their last known versions:
github.com/alessio/shellescapeis replaced withgithub.com/alessio/shellescape v1.4.2github.com/imdario/mergois replaced withgithub.com/imdario/mergo v0.3.16
- Updating other dependencies: Several other dependencies have been updated to their latest versions. This includes updates to
github.com/aws/aws-sdk-go-v2/config,github.com/aws/aws-sdk-go-v2/credentials,github.com/aws/aws-sdk-go-v2/service/ecr, andgithub.com/aws/aws-sdk-go-v2/service/sts, among others. The specific version changes are detailed in the diffs forgo.modandgo.sum. - Updating import path: The import path for the
mergolibrary inpkg/skaffold/config/util.gohas been updated fromgithub.com/imdario/mergotodario.cat/mergo(line 30). - Improvements to
godirwalkdocumentation and error handling: The documentation for thegodirwalklibrary has been improved to include instructions on preventing resource leaks (lines 26-29, 58-63, 81-83, 118-121 ofscandir_unix.goand lines 21-24, 58-67, 72-74, 109-112 ofscandir_windows.go). Error handling has also been improved inscandir_unix.go(lines 102-111, 150-156) andscandir_windows.go(lines 96-107).
The changes to go.sum reflect the updated dependency versions. The modules.txt file also shows the changes made to the dependencies.
I've reviewed the changes and they appear to be well-structured and thoroughly documented. I'll provide a more detailed review shortly.
And now, a little haiku to lighten the mood:
Go modules clean,
Dependencies aligned now,
Code flows smoothly.
ghost
left a comment
There was a problem hiding this comment.
This PR cleans up the go.mod file by removing an outdated exclude directive and pinning dependencies that have changed paths. This is good practice for dependency management and ensures reproducible builds. The changes are well-justified and follow the recommendations from the mergo readme.
a05aad3 to
65cbaab
Compare
Uh oh!
There was an error while loading. Please reload this page.