Skip to content

feat(config): Enhance config list/set output#9780

Merged
Darien-Lin merged 1 commit into
GoogleContainerTools:mainfrom
idsulik:feat-config
Apr 14, 2025
Merged

feat(config): Enhance config list/set output#9780
Darien-Lin merged 1 commit into
GoogleContainerTools:mainfrom
idsulik:feat-config

Conversation

@idsulik

@idsulik idsulik commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

Description
Enhanced config list/set output.

  • list: it's not obvious what happens when there is no config because the command returns empty output, now it shows a correct message.
    No config found for сurrent context "stage-nbg3"

  • set: if you pass a wrong field name, it just says you passed a wrong field, but I think it'll be better to output what fields are valid:

    "test" is not a valid config field.
    Available fields are: debug-helpers-registry, update-check, survey, collect-metrics, update, kube-context, omitempty, 
    default-repo, local-cluster, kind-disable-load, k3d-disable-load, multi-level-repo, insecure-registries
    
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
@idsulik idsulik requested a review from a team as a code owner April 8, 2025 04:47
@Darien-Lin Darien-Lin merged commit 8c00b98 into GoogleContainerTools:main Apr 14, 2025
@idsulik idsulik deleted the feat-config branch April 14, 2025 14:28
@menahyouyeah menahyouyeah mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants