Skip to content

disabling kaniko integration tests due to kaniko service account permissions issue#9943

Merged
Darien-Lin merged 1 commit into
GoogleContainerTools:mainfrom
Darien-Lin:main
Jan 6, 2026
Merged

disabling kaniko integration tests due to kaniko service account permissions issue#9943
Darien-Lin merged 1 commit into
GoogleContainerTools:mainfrom
Darien-Lin:main

Conversation

@Darien-Lin

Copy link
Copy Markdown
Contributor

Description

Currently disable the kaniko integration tests because of some infrastructure issue with testing on GCP. Will be reenabled in the future by @menahyouyeah

@Darien-Lin Darien-Lin requested a review from a team as a code owner January 6, 2026 20:31
@google-cla

google-cla Bot commented Jan 6, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Darien-Lin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a recurring failure in the CI/CD pipeline by temporarily disabling several Kaniko integration tests. The failures stem from an infrastructure-related problem with Kaniko service account permissions on GCP. By commenting out these tests, the PR aims to unblock the pipeline while a permanent solution to the permissions issue is being worked on, with the intention to re-enable them once the problem is resolved.

Highlights

  • Kaniko Integration Tests Disabled: A suite of Kaniko-related integration tests has been temporarily disabled in integration/run_test.go.
  • Reason for Disablement: The tests are disabled due to an infrastructure issue concerning Kaniko service account permissions on Google Cloud Platform (GCP).
  • Future Re-enablement: These tests are intended to be re-enabled in the future once the underlying permissions issue is resolved.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the Kaniko integration tests by commenting them out due to a service account permission issue. My feedback focuses on improving the trackability of this temporary change by adding a more descriptive TODO comment, which is consistent with how other tests are disabled in this file. This will help ensure the tests are re-enabled once the underlying issue is resolved.

Comment thread integration/run_test.go
dir: "testdata/kaniko-microservices",
deployments: []string{"leeroy-app", "leeroy-web"},
},
// Currently disable kaniko integration tests due to kaniko service account issues.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better tracking and to ensure these tests are re-enabled in the future, it's good practice to add a TODO comment with a reference. This is also consistent with other disabled tests in this file (e.g., line 157). Please include the user handle mentioned in the PR description to make it clear who is responsible for re-enabling them.

Suggested change
// Currently disable kaniko integration tests due to kaniko service account issues.
// TODO(@menahyouyeah): Re-enable kaniko integration tests once service account issues are resolved.
ChrisGe4
ChrisGe4 previously approved these changes Jan 6, 2026
permissioning issue and fix github workflow
@Darien-Lin Darien-Lin merged commit e0cafba into GoogleContainerTools:main Jan 6, 2026
11 of 12 checks passed
mattsanta pushed a commit to mattsanta/skaffold that referenced this pull request Jan 7, 2026
…permissions issue and fix github workflow (GoogleContainerTools#9943)

disabling kaniko integration tests due to kaniko service accountpermissioning issue and fix github workflow

Co-authored-by: Darien-Lin <darienl@google.com>
@mattsanta mattsanta mentioned this pull request Jan 7, 2026
mattsanta added a commit that referenced this pull request Jan 7, 2026
* chore: bump golang.org/x/crypto from 0.43.0 to 0.45.0 (#9917)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0.
- [Commits](golang/crypto@v0.43.0...v0.45.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.45.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: bump the github-actions group across 1 directory with 3 updates (#9934)

Bumps the github-actions group with 3 updates in the / directory: [actions/checkout](https://github.com/actions/checkout), [actions/cache](https://github.com/actions/cache) and [actions/upload-artifact](https://github.com/actions/upload-artifact).


Updates `actions/checkout` from 5 to 6
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5...v6)

Updates `actions/cache` from 4 to 5
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v4...v5)

Updates `actions/upload-artifact` from 5 to 6
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v5...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: actions/cache
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: actions/upload-artifact
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: disabling kaniko integration tests due to kaniko service account permissions issue and fix github workflow (#9943)

disabling kaniko integration tests due to kaniko service accountpermissioning issue and fix github workflow

Co-authored-by: Darien-Lin <darienl@google.com>

* chore: upgrade golang to 1.25.5 (#9944)

* Upgrade github.com/google/ko to v0.18.1 (#9939)

* Upgrade github.com/google/ko to v0.18.1

* Upgrade github.com/google/ko to v0.18.1 continue

* fix a issue in docker/auth.go

* fix go version issue in test

* revert go version changes in test

* update docker cli vendor files

* Trigger GitHub Actions

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Darien Lin <lind3686@gmail.com>
Co-authored-by: Darien-Lin <darienl@google.com>
Co-authored-by: Chris <chris.ge@live.com>
orospakr pushed a commit to orospakr/skaffold-spawnexec that referenced this pull request May 14, 2026
…permissions issue and fix github workflow (GoogleContainerTools#9943)

disabling kaniko integration tests due to kaniko service accountpermissioning issue and fix github workflow

Co-authored-by: Darien-Lin <darienl@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants