chore: upgrade golang to 1.25.7#9973
Conversation
Summary of ChangesHello @Darien-Lin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Go language version for the Skaffold project from 1.25.5 to 1.25.7. This ensures that the project leverages the latest stable Go release, incorporating any performance improvements, bug fixes, and security updates provided in the newer version, and maintains consistency across the build environment and module definitions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the Go version from 1.25.5 to 1.25.7. The changes in go.mod and deploy/skaffold/Dockerfile.deps are consistent. However, the version 1.25.7 does not correspond to a public Go release. This can cause build and tooling issues for contributors outside of the project's specific build environment. I've added comments with suggestions to improve reproducibility by using public versions or fully qualified image names.
| apt-transport-https && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
| COPY --from=golang:1.25.5 /usr/local/go /usr/local/go | ||
| COPY --from=golang:1.25.7 /usr/local/go /usr/local/go |
There was a problem hiding this comment.
The golang:1.25.7 image tag does not appear to be a publicly available official Go image. This can cause build failures for contributors or anyone building this Dockerfile outside of the project's specific CI environment where this image might be available. For better reproducibility, it is recommended to use an official Go version. If this is a custom image, please consider using a fully qualified image name that includes the registry (e.g., gcr.io/my-project/golang:1.25.7).
| module github.com/GoogleContainerTools/skaffold/v2 | ||
|
|
||
| go 1.25.5 | ||
| go 1.25.7 |
There was a problem hiding this comment.
The Go version 1.25.7 is not a public Go release. This can lead to issues for developers trying to build or test the project, as their local Go toolchain will likely not support this version. It is recommended to use a publicly available Go version to ensure a consistent and accessible development environment for all contributors.
There was a problem hiding this comment.
Hm.. Odd.. It seems public though: go/go-release-history#go1.25.minor
| module github.com/GoogleContainerTools/skaffold/v2 | ||
|
|
||
| go 1.25.5 | ||
| go 1.25.7 |
There was a problem hiding this comment.
Hm.. Odd.. It seems public though: go/go-release-history#go1.25.minor
|
Actually, WDYT about not specifying the minor version at all? |
fair point, we could do that in the future. For now, in the interest of cutting a release, I'll follow our internal playbook as is. |
Co-authored-by: Darien-Lin <darienl@google.com>
* chore: bump github.com/sigstore/cosign/v2 from 2.6.1 to 2.6.2 (#9948) Bumps [github.com/sigstore/cosign/v2](https://github.com/sigstore/cosign) from 2.6.1 to 2.6.2. - [Release notes](https://github.com/sigstore/cosign/releases) - [Changelog](https://github.com/sigstore/cosign/blob/main/CHANGELOG.md) - [Commits](sigstore/cosign@v2.6.1...v2.6.2) --- updated-dependencies: - dependency-name: github.com/sigstore/cosign/v2 dependency-version: 2.6.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * cicd: bazel github presubmit flow fixes for recent bazel 9.0.0 release (#9961) bazel build fixes for recent bazel 9.0.0 release * chore: bump github.com/sigstore/sigstore from 1.10.3 to 1.10.4 (#9957) Bumps [github.com/sigstore/sigstore](https://github.com/sigstore/sigstore) from 1.10.3 to 1.10.4. - [Release notes](https://github.com/sigstore/sigstore/releases) - [Commits](sigstore/sigstore@v1.10.3...v1.10.4) --- updated-dependencies: - dependency-name: github.com/sigstore/sigstore dependency-version: 1.10.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump github.com/sigstore/rekor from 1.4.3 to 1.5.0 (#9956) Bumps [github.com/sigstore/rekor](https://github.com/sigstore/rekor) from 1.4.3 to 1.5.0. - [Release notes](https://github.com/sigstore/rekor/releases) - [Changelog](https://github.com/sigstore/rekor/blob/main/CHANGELOG.md) - [Commits](sigstore/rekor@v1.4.3...v1.5.0) --- updated-dependencies: - dependency-name: github.com/sigstore/rekor dependency-version: 1.5.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump github.com/theupdateframework/go-tuf/v2 from 2.3.0 to 2.4.1 (#9962) Bumps [github.com/theupdateframework/go-tuf/v2](https://github.com/theupdateframework/go-tuf) from 2.3.0 to 2.4.1. - [Release notes](https://github.com/theupdateframework/go-tuf/releases) - [Commits](theupdateframework/go-tuf@v2.3.0...v2.4.1) --- updated-dependencies: - dependency-name: github.com/theupdateframework/go-tuf/v2 dependency-version: 2.4.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(integration): Update busybox and alpine:3 to use the mirror to avoid docker rate hub limit errors (#9966) test(integration): mirror busybox and alpine:3 images to gcr.io * chore: bump github.com/go-git/go-git/v5 from 5.16.3 to 5.16.5 (#9971) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.16.3 to 5.16.5. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.16.3...v5.16.5) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-version: 5.16.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump golang.org/x/oauth2 from 0.7.0 to 0.27.0 in /examples/grpc-e2e-tests/service (#9918) chore: bump golang.org/x/oauth2 in /examples/grpc-e2e-tests/service Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.7.0 to 0.27.0. - [Commits](golang/oauth2@v0.7.0...v0.27.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-version: 0.27.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump golang.org/x/crypto from 0.36.0 to 0.45.0 in /hack/tools (#9916) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.36.0 to 0.45.0. - [Commits](golang/crypto@v0.36.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Use mirror in Dockerfiles for integration tests to prevent docker hub rate limits (#9970) * use mirror in Dockerfiles for integration tests * use argument prefix instead * fix for multi stage * more fixes * fix buildx-bin error * Bring back comments * missed a comment * chore: upgrade golang to 1.25.7 (#9973) Co-authored-by: Darien-Lin <darienl@google.com> * Updated Dockerfile to try to fix vuln bug (#9974) * Updated Dockerfile to try to fix vuln bug * Addressed the gemini-code-assist comments * Fixed the dockerfile so it runs using docker build -f deploy/webhook-v2/Dockerfile . * Updated the node version to fix error (#9976) * Updated Dockerfile to try to fix vuln bug * Addressed the gemini-code-assist comments * Fixed the dockerfile so it runs using docker build -f deploy/webhook-v2/Dockerfile . * Updated node version to try and fix error * chore: fixing docs due to upgrade in Hugo (#9977) fixing docs due to upgrade in Hugo --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: menahyouyeah <minnah@google.com> Co-authored-by: Darien-Lin <darienl@google.com> Co-authored-by: ruhi-chaddha <ruhichaddha@google.com>
Co-authored-by: Darien-Lin <darienl@google.com>
Description
version bump for golang for skaffold project.