Skip to content

chore: upgrade golang to 1.25.7#9973

Merged
Darien-Lin merged 2 commits into
GoogleContainerTools:mainfrom
Darien-Lin:main
Feb 10, 2026
Merged

chore: upgrade golang to 1.25.7#9973
Darien-Lin merged 2 commits into
GoogleContainerTools:mainfrom
Darien-Lin:main

Conversation

@Darien-Lin

Copy link
Copy Markdown
Contributor

Description

version bump for golang for skaffold project.

@Darien-Lin Darien-Lin requested a review from a team as a code owner February 10, 2026 21:23
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Darien-Lin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Go language version for the Skaffold project from 1.25.5 to 1.25.7. This ensures that the project leverages the latest stable Go release, incorporating any performance improvements, bug fixes, and security updates provided in the newer version, and maintains consistency across the build environment and module definitions.

Highlights

  • Go Version Upgrade: The Go version used across the project has been upgraded from 1.25.5 to 1.25.7.
  • Dockerfile Update: The Dockerfile.deps now uses the golang:1.25.7 base image for building.
  • Module Definition Update: The go.mod file has been updated to declare Go version 1.25.7.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • deploy/skaffold/Dockerfile.deps
    • Updated the COPY --from instruction to use golang:1.25.7 instead of golang:1.25.5.
  • go.mod
    • Changed the declared Go version from 1.25.5 to 1.25.7.
Ignored Files
  • Ignored by pattern: .github/workflows/** (6)
    • .github/workflows/integration-linux.yml
    • .github/workflows/linters-checks.yml
    • .github/workflows/unit-tests-darwin.yml
    • .github/workflows/unit-tests-linux.yml
    • .github/workflows/unit-tests-windows.yml
    • .github/workflows/verify-examples.yml
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the Go version from 1.25.5 to 1.25.7. The changes in go.mod and deploy/skaffold/Dockerfile.deps are consistent. However, the version 1.25.7 does not correspond to a public Go release. This can cause build and tooling issues for contributors outside of the project's specific build environment. I've added comments with suggestions to improve reproducibility by using public versions or fully qualified image names.

Comment thread deploy/skaffold/Dockerfile.deps Outdated
apt-transport-https && \
rm -rf /var/lib/apt/lists/*
COPY --from=golang:1.25.5 /usr/local/go /usr/local/go
COPY --from=golang:1.25.7 /usr/local/go /usr/local/go

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The golang:1.25.7 image tag does not appear to be a publicly available official Go image. This can cause build failures for contributors or anyone building this Dockerfile outside of the project's specific CI environment where this image might be available. For better reproducibility, it is recommended to use an official Go version. If this is a custom image, please consider using a fully qualified image name that includes the registry (e.g., gcr.io/my-project/golang:1.25.7).

Comment thread go.mod
module github.com/GoogleContainerTools/skaffold/v2

go 1.25.5
go 1.25.7

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Go version 1.25.7 is not a public Go release. This can lead to issues for developers trying to build or test the project, as their local Go toolchain will likely not support this version. It is recommended to use a publicly available Go version to ensure a consistent and accessible development environment for all contributors.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.. Odd.. It seems public though: go/go-release-history#go1.25.minor

@Darien-Lin Darien-Lin self-assigned this Feb 10, 2026
Comment thread go.mod
module github.com/GoogleContainerTools/skaffold/v2

go 1.25.5
go 1.25.7

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.. Odd.. It seems public though: go/go-release-history#go1.25.minor

@Darien-Lin Darien-Lin merged commit b3f4a30 into GoogleContainerTools:main Feb 10, 2026
14 of 17 checks passed
@kkarrenn

Copy link
Copy Markdown

Actually, WDYT about not specifying the minor version at all?

@Darien-Lin

Copy link
Copy Markdown
Contributor Author

Actually, WDYT about not specifying the minor version at all?

fair point, we could do that in the future. For now, in the interest of cutting a release, I'll follow our internal playbook as is.

Darien-Lin added a commit to Darien-Lin/skaffold that referenced this pull request Feb 12, 2026
Co-authored-by: Darien-Lin <darienl@google.com>
@Darien-Lin Darien-Lin mentioned this pull request Feb 12, 2026
Darien-Lin added a commit that referenced this pull request Feb 12, 2026
* chore: bump github.com/sigstore/cosign/v2 from 2.6.1 to 2.6.2 (#9948)

Bumps [github.com/sigstore/cosign/v2](https://github.com/sigstore/cosign) from 2.6.1 to 2.6.2.
- [Release notes](https://github.com/sigstore/cosign/releases)
- [Changelog](https://github.com/sigstore/cosign/blob/main/CHANGELOG.md)
- [Commits](sigstore/cosign@v2.6.1...v2.6.2)

---
updated-dependencies:
- dependency-name: github.com/sigstore/cosign/v2
  dependency-version: 2.6.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* cicd: bazel github presubmit flow fixes for recent bazel 9.0.0 release (#9961)

bazel build fixes for recent bazel 9.0.0 release

* chore: bump github.com/sigstore/sigstore from 1.10.3 to 1.10.4 (#9957)

Bumps [github.com/sigstore/sigstore](https://github.com/sigstore/sigstore) from 1.10.3 to 1.10.4.
- [Release notes](https://github.com/sigstore/sigstore/releases)
- [Commits](sigstore/sigstore@v1.10.3...v1.10.4)

---
updated-dependencies:
- dependency-name: github.com/sigstore/sigstore
  dependency-version: 1.10.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: bump github.com/sigstore/rekor from 1.4.3 to 1.5.0 (#9956)

Bumps [github.com/sigstore/rekor](https://github.com/sigstore/rekor) from 1.4.3 to 1.5.0.
- [Release notes](https://github.com/sigstore/rekor/releases)
- [Changelog](https://github.com/sigstore/rekor/blob/main/CHANGELOG.md)
- [Commits](sigstore/rekor@v1.4.3...v1.5.0)

---
updated-dependencies:
- dependency-name: github.com/sigstore/rekor
  dependency-version: 1.5.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: bump github.com/theupdateframework/go-tuf/v2 from 2.3.0 to 2.4.1 (#9962)

Bumps [github.com/theupdateframework/go-tuf/v2](https://github.com/theupdateframework/go-tuf) from 2.3.0 to 2.4.1.
- [Release notes](https://github.com/theupdateframework/go-tuf/releases)
- [Commits](theupdateframework/go-tuf@v2.3.0...v2.4.1)

---
updated-dependencies:
- dependency-name: github.com/theupdateframework/go-tuf/v2
  dependency-version: 2.4.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* test(integration): Update busybox and alpine:3 to use the mirror to avoid docker rate hub limit errors (#9966)

test(integration): mirror busybox and alpine:3 images to gcr.io

* chore: bump github.com/go-git/go-git/v5 from 5.16.3 to 5.16.5 (#9971)

Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.16.3 to 5.16.5.
- [Release notes](https://github.com/go-git/go-git/releases)
- [Commits](go-git/go-git@v5.16.3...v5.16.5)

---
updated-dependencies:
- dependency-name: github.com/go-git/go-git/v5
  dependency-version: 5.16.5
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: bump golang.org/x/oauth2 from 0.7.0 to 0.27.0 in /examples/grpc-e2e-tests/service (#9918)

chore: bump golang.org/x/oauth2 in /examples/grpc-e2e-tests/service

Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.7.0 to 0.27.0.
- [Commits](golang/oauth2@v0.7.0...v0.27.0)

---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
  dependency-version: 0.27.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: bump golang.org/x/crypto from 0.36.0 to 0.45.0 in /hack/tools (#9916)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.36.0 to 0.45.0.
- [Commits](golang/crypto@v0.36.0...v0.45.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.45.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Use mirror in Dockerfiles for integration tests to prevent docker hub rate limits (#9970)

* use mirror in Dockerfiles for integration tests

* use argument prefix instead

* fix for multi stage

* more fixes

* fix buildx-bin error

* Bring back comments

* missed a comment

* chore: upgrade golang to 1.25.7 (#9973)

Co-authored-by: Darien-Lin <darienl@google.com>

* Updated Dockerfile to try to fix vuln bug (#9974)

* Updated Dockerfile to try to fix vuln bug

* Addressed the gemini-code-assist comments

* Fixed the dockerfile so it runs using docker build -f deploy/webhook-v2/Dockerfile .

* Updated the node version to fix error (#9976)

* Updated Dockerfile to try to fix vuln bug

* Addressed the gemini-code-assist comments

* Fixed the dockerfile so it runs using docker build -f deploy/webhook-v2/Dockerfile .

* Updated node version to try and fix error

* chore: fixing docs due to upgrade in Hugo (#9977)

fixing docs due to upgrade in Hugo

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: menahyouyeah <minnah@google.com>
Co-authored-by: Darien-Lin <darienl@google.com>
Co-authored-by: ruhi-chaddha <ruhichaddha@google.com>
orospakr pushed a commit to orospakr/skaffold-spawnexec that referenced this pull request May 14, 2026
Co-authored-by: Darien-Lin <darienl@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants