There are four files - two new and two existing - #77
Open
MarkJosephBennett wants to merge 8 commits into
Open
MarkJosephBennett wants to merge 8 commits into
MarkJosephBennett wants to merge 8 commits into
Conversation
We have modified notebooks/cvar_basic.ipynb and notebooks/mean_variance_basic.ipynb to take advantage of src/portcolio_components.py display routines and those are unit tested by the 4th file, test/test_portfolio_components. This provides a way for the user to see the in-sample marked-to-market behavior of the cuOpt-PO recommended portfolio of securities without the cash component.
Unit tests for src/portfolio_components.py
MarkJosephBennett
requested review from
jgoldberg-nvidia and
tmckayus
and removed request for
a team
September 11, 2026 21:30
src/portfolio_components.py is for displaying the portfolio component securities marked to market.
These file are modified to accept a modified upper cell and additional middle cells to invoke the src/portfolio_components.py logic for displaying new plot.
wrong directory.
Wrong directory.
Wrong directory.
Wrong directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have modified notebooks/cvar_basic.ipynb and notebooks/mean_variance_basic.ipynb to take advantage of src/portcolio_components.py display routines and those are unit tested by the 4th file, test/test_portfolio_components.
This provides a way for the user to see the in-sample marked-to-market behavior of the cuOpt-PO recommended portfolio of securities without the cash component.