Skip to content

fix(common): seed Lhotse RIR from shard seed - #16298

Open
rohan-patnaik wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
rohan-patnaik:fix/rir-shard-seed
Open

rohan-patnaik wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
rohan-patnaik:fix/rir-shard-seed

Conversation

@rohan-patnaik

@rohan-patnaik rohan-patnaik commented Sep 25, 2026 •

Copy link
Copy Markdown

Important

An outdated branch does not block merging; use Update branch only after consulting the automation team.

What does this PR do ?

Fixes #16100 by seeding Lhotse RIR augmentation from shard_seed, so default distributed ranks no longer draw identical reverb streams.

Collection: common (Lhotse dataloader)

Changelog

  • Resolve config.shard_seed for ReverbWithImpulseResponse.
  • Test independent default rank streams and fixed-seed reproducibility.

Usage

No configuration change. Integer shard_seed values remain deterministic. Existing "randomized" worker semantics are unchanged.

GitHub Actions CI

test_lhotse_dataloading.py: 73 passed, 1 skipped; pre-commit passes. Both new regressions fail on base.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation? (N/A: follows the existing contract)
  • Does the PR affect components that are optional to install?
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Additional Information

Revisits closed, unmerged PR #16101. Related #14322 is a broader, currently conflicted refactor.

Signed-off-by: Rohan Patnaik <rohan-patnaik@users.noreply.github.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the waiting-on-maintainers Waiting on maintainers to respond label Sep 27, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants