fix(common): seed Lhotse RIR from shard seed - #16298
Open
rohan-patnaik wants to merge 1 commit into
Open
rohan-patnaik wants to merge 1 commit into
rohan-patnaik wants to merge 1 commit into
Conversation
Signed-off-by: Rohan Patnaik <rohan-patnaik@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
An outdated branch does not block merging; use Update branch only after consulting the automation team.
What does this PR do ?
Fixes #16100 by seeding Lhotse RIR augmentation from
shard_seed, so default distributed ranks no longer draw identical reverb streams.Collection: common (Lhotse dataloader)
Changelog
config.shard_seedforReverbWithImpulseResponse.Usage
No configuration change. Integer
shard_seedvalues remain deterministic. Existing"randomized"worker semantics are unchanged.GitHub Actions CI
test_lhotse_dataloading.py: 73 passed, 1 skipped; pre-commit passes. Both new regressions fail on base.Before your PR is "Ready for review"
Pre checks:
PR Type:
Additional Information
Revisits closed, unmerged PR #16101. Related #14322 is a broader, currently conflicted refactor.