Skip to content

fix(asr): restore legacy boosting-tree config compatibility - #16305

Open
rohan-patnaik wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
rohan-patnaik:fix/boosting-tree-config-compat
Open

rohan-patnaik wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
rohan-patnaik:fix/boosting-tree-config-compat

Conversation

@rohan-patnaik

Copy link
Copy Markdown

What does this PR do ?

Fills fields missing from legacy boosting-tree DictConfig values with current structured defaults before reading them. This restores checkpoint compatibility without disabling struct validation. Fixes #15658.

Collection: ASR

Changelog

  • Normalize legacy boosting-tree configs at emptiness checks and model construction.
  • Cover configs missing one field or several fields while preserving saved overrides.

Before your PR is "Ready for review"

Pre checks:

  • Read and followed the contributor guidelines.
  • Added regression tests; 25 adjacent CPU tests also pass (one Triton-only skip).
  • No documentation update is needed because this restores existing checkpoint-loading behavior.
  • No optional-install component is affected.

PR Type:

  • Bugfix

Additional Information

Fixes #15658.

Signed-off-by: Rohan Patnaik <rohan-patnaik@users.noreply.github.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the ASR label Sep 27, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the waiting-on-maintainers Waiting on maintainers to respond label Sep 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASR community-request waiting-on-maintainers Waiting on maintainers to respond

2 participants