Skip to content

ci(review): AUT-2439 migrate legacy Claude commands to /review - #16328

Open
svcnemo-autobot wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:ci/migrate-legacy-review
Open

svcnemo-autobot wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:ci/migrate-legacy-review

Conversation

@svcnemo-autobot

Copy link
Copy Markdown
Contributor

Background

Extend the migration from NVIDIA/Megatron-LM#7675 to Speech.

What changed

  • Replace legacy Claude review execution with least-privilege migration notices.
  • Preserve Speech's substantive rubric and adapt it to formal review submission.
  • Document replacement commands and rollout prerequisites.
  • Add regression tests for permissions, command mapping, and literal shell arguments.

Details

flowchart LR
  Legacy[Legacy command] --> Notice[Migration notice]
  User[User posts /review] --> Service[Formal reviewer]
  Service --> Rubric[Protected Speech rubric]
Loading

Bot comments are ignored; the notice job performs no checkout or inference. Publish the protected-main rubric and verify its registered profile and Ready plugin snapshot before relying on the redirect. Activation has not been verified; no merge or deployment is requested.

Tested

Candidate merge checkout: repository pre-commit checks passed; six isolated tests passed with --noconftest -c /dev/null (diagnostic only). Normal pytest ... --cpu exited before tests because test_data.tar.gz was unavailable; release metadata access was denied by the broker. Full repository CI remains unverified. SSH signature and pushed fork head verified.

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot
svcnemo-autobot requested a review from a team as a code owner October 1, 2026 10:51
@copy-pr-bot

copy-pr-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the CI label Oct 1, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added documentation Improvements or additions to documentation python Pull requests that update python code labels Oct 1, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test a7a2ded

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

[🤖]: Hi @svcnemo-autobot 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

This branch was successfully deployed

2 active deployments
public — a7a2ded3 Deployed Oct 1, 2026 by copy-pr-bot[bot] via release / finalize / publish-docs #1610
test — a7a2ded3 Deployed Oct 1, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #21219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI documentation Improvements or additions to documentation python Pull requests that update python code

2 participants