Fix "current stage of a USD stage" -> "current state of a USD stage" typo - #97
hikmetba-bit wants to merge 1 commit into
Conversation
…typo UsdStage::Save's description in stage.md said it saves the "current stage of a USD stage", which doesn't parse. It saves the stage's current state (its edited layers) back to a file, which is what the rest of the sentence describes. Fixes NVIDIA-Omniverse#96 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dillonbbailey
left a comment
There was a problem hiding this comment.
Thanks! The fix is correct: "current stage of a USD stage" was a typo for "state", and this is the only instance in docs/.
Must fix before merge
-
DCO sign-off missing.
CONTRIBUTING.mdrequires aSigned-off-by:line on every commit, and unsigned commits can't be accepted. Commit692f34fonly has aCo-Authored-Bytrailer. -
Commit author identity. The commit is authored as
noreply@anthropic.com, so it isn't tied to your GitHub identity, and a sign-off only means something under your own name and email. With your git config set to your own identity, run:git commit --amend --reset-author -s --no-edit git push --force-with-lease
Optional
- Same bullet: "all edited layers that contribute to the stage are being saved" would read better as "are saved". Fine to include here or leave.
Also a thank-you to @NGGW519 for reporting this in #96.
🤖 Review assisted by Claude Code
|
FYI, I opened #100 as a signed-off alternative that also includes the optional "are saved" wording. As the reporter of #96, I had offered to submit the fix once the issue was confirmed, so I'd appreciate it if #100 could be considered. It's ready to merge as-is. That said, I'll defer to your decision, @dillonbbailey. |
docs/stage-setting/stage.mdline 92, describingUsdStage::Save:"stage of a USD stage" doesn't parse — the rest of the sentence describes saving the stage's edited layers back to disk, i.e. its current state:
Verified this is the only occurrence of the typo in the file; the rest of the "current stage" usages elsewhere are correct.
Fixes #96
🤖 Generated with Claude Code