Skip to content

feat(uat): enroll azure-h100 in the nightly batch with [training] - #1726

Merged
mchmarny merged 1 commit into
mainfrom
feat/azure-nightly-enrollment
Jul 10, 2026
Merged

mchmarny merged 1 commit into
mainfrom
feat/azure-nightly-enrollment

Conversation

@mchmarny

Copy link
Copy Markdown
Member

Summary

Enrolls azure-h100 in the nightly UAT batch with nightly-intents: [training], ending its bring-up manual-dispatch-only phase. Updates the uat.md enrollment table/prose and the committed-registry lock-in test.

Motivation / Context

The stated gate for flipping azure-h100 off nightly-intents: [] was a green manual run. The acceptance run (29125390442) completed green end-to-end: provision → prep → install → validate (all phases) → TrainJob → verify → signed-evidence ingest to the corroboration bucket (now rendered on validation.aicr.run) → clean teardown.

Training-only for now: inference joins after a green manual intent=inference dispatch, matching how the intent set is data-driven per reservation. (The serve CUJ step remains disabled on all clouds pending #1644, so an Azure inference cell would provision + validate the inference stack, same as AWS/GCP.)

Fixes: N/A
Related: #1709, #1722, #1275, #1276

Type of Change

  • Build/CI/tooling

Component(s) Affected

  • Docs/examples (docs/)
  • Other: UAT reservation registry (infra/uat/reservations.yaml), pkg/uatbroker lock-in test

Implementation Notes

  • The registry comment keeps the authoring caveat visible: add inference to the list rather than removing the key (a bare nightly-intents: decodes as absent and defaults to [training]).
  • TestCommittedRegistryValid updated — it deliberately pins the committed intent set, so this data change fails the test without the matching expectation change.

Testing

GOFLAGS=-mod=vendor go test -race ./pkg/uatbroker/... ./tools/uat-broker/...  # ok
golangci-lint run -c .golangci.yaml ./pkg/uatbroker/...                       # 0 issues
yamllint -c .yamllint.yaml infra/uat/reservations.yaml                        # clean
  • Coverage gate: test-only Go change (expectation update); no new exported surface.
  • Behavior exercised by tonight's uat-nightly-batch.yaml cron (0 4 UTC) — the azure-h100 training cell dispatches through the same uat-run path the acceptance run used.

Risk Assessment

  • Low — Data + docs + test expectation. Revert restores the opt-out. Worst case is a red nightly cell on a lane that just passed its acceptance run.

Checklist

  • Tests pass locally (make test with -race)
  • Linter passes (make lint)
  • I did not skip/disable tests to make CI green
  • I added/updated tests for new functionality (lock-in test expectation)
  • I updated docs if user-facing behavior changed (docs/contributor/uat.md)
  • Changes follow existing patterns in the codebase
  • Commits are cryptographically signed (git commit -S)
The Azure UAT acceptance run (29125390442) went green end-to-end —
provision, prep, install, validate all phases, TrainJob, verify,
signed-evidence ingest to the corroboration bucket, and clean teardown
— which was the stated gate for flipping azure-h100 off its bring-up
opt-out. Enrolls [training] only; inference joins after a green manual
intent=inference dispatch (the serve CUJ step remains disabled pending
#1644 on all clouds, matching AWS/GCP). Updates the uat.md enrollment
table/prose and the committed-registry lock-in test.

Signed-off-by: Mark Chmarny <mark@chmarny.com>
@mchmarny
mchmarny requested review from a team as code owners July 10, 2026 23:11
@mchmarny mchmarny added the theme/validation Constraint evaluation, health checks, and conformance evidence label Jul 10, 2026
@mchmarny mchmarny self-assigned this Jul 10, 2026
@mchmarny
mchmarny merged commit f37bba2 into main Jul 10, 2026
34 of 36 checks passed
@mchmarny
mchmarny deleted the feat/azure-nightly-enrollment branch July 10, 2026 23:12
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: b37ea639-b8cc-4781-9e03-b235144de7b5

📥 Commits

Reviewing files that changed from the base of the PR and between b39d4a0 and 695425a.

📒 Files selected for processing (3)
  • docs/contributor/uat.md
  • infra/uat/reservations.yaml
  • pkg/uatbroker/registry_test.go

📝 Walkthrough

Walkthrough

Azure H100 is enrolled in nightly training through the reservation configuration, with registry validation updated to expect IntentTraining. UAT documentation now describes inference enrollment after a successful manual run, notes that the serving CUJ remains disabled pending issue 1644, and generalizes the queued-reservation example to cover nightly and ad-hoc dispatches.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • NVIDIA/aicr#1709: Directly relates to the azure-h100 nightly-intents configuration and registry behavior.

Suggested labels: area/tests

Suggested reviewers: njhensley

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/azure-nightly-enrollment

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report ✅

Metric Value
Coverage 78.7%
Threshold 75%
Status Pass
Coverage Badge
![Coverage](https://img.shields.io/badge/coverage-78.7%25-green)

No Go source files changed in this PR.

mohityadav8 pushed a commit to mohityadav8/aicr that referenced this pull request Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs area/infra size/S theme/validation Constraint evaluation, health checks, and conformance evidence

1 participant