fix(audit): remove useless borrow in syslog format! argument - #11
Merged
fylorn merged 1 commit intoSep 12, 2026
Merged
Conversation
Trivial clippy::useless_borrows_in_formatting fix. Not connected to any other change -- found while running clippy locally ahead of an unrelated PR and noticed CI's Rust job pulls dtolnay/rust-toolchain@stable unpinned, so this trips CI on the current stable release even though it was clean when main last built (2026-05-27). Submitted standalone so it does not distract from that PR's diff.
fylorn
pushed a commit
that referenced
this pull request
Sep 12, 2026
Fixes CI: clippy 1.98's useless_borrows_in_formatting is an error under -D warnings.
fylorn
added a commit
that referenced
this pull request
Sep 12, 2026
Three separate things, all found by upgrading the local toolchain from 1.95 to 1.98 — the same gap that let #11's lint reach main unnoticed. - `useless_borrows_in_formatting` fires in two more places that #11 didn't touch: `crates/server/src/handlers/log_forwarders.rs` and `crates/test-support/tests/body_offload.rs`. Same one-character fix. - `result_large_err` on the two MCP lifecycle stages is a false positive here, and the comment says so with numbers: the `Ok` variant is 296 bytes against the `Err`'s 152, so the `Result` is sized by `Ok` either way, and `Box<JsonRpcResponse>` measures the same 296 while adding an allocation on the short-circuit path. Allowed rather than boxed, with the measurement recorded so nobody "fixes" it later. - `Cargo.lock` repointed at core's current `main`. Core's history was rewritten (commit messages translated to English), so every SHA changed and the previously locked one is no longer reachable. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial
clippy::useless_borrows_in_formattingfix incrates/common/src/audit/forwarders.rs.Not connected to any other change. Found while running
cargo clippy --workspacelocally ahead of an unrelated PR — CI's Rust job pullsdtolnay/rust-toolchain@stableunpinned, so this trips on the current stable Rust release even though it was clean whenmainlast built (2026-05-27). Submitted standalone so it doesn't distract from that PR's diff.Verified:
cargo clippy -p think-watch-common --all-targets -- -D warningspasses after this change.