Add targetAddressSpace integration in WebSockets - #125
Open
christhompson wants to merge 2 commits into
Open
christhompson wants to merge 2 commits into
christhompson wants to merge 2 commits into
Conversation
annevk
reviewed
Aug 17, 2026
| 1. If |protocolsOrOptions|["{{WebSocketInit/targetAddressSpace}}"] [=map/exists=], then | ||
| switch on |protocolsOrOptions|["{{WebSocketInit/targetAddressSpace}}"]: | ||
| <dl class=switch> | ||
| <dt>public |
There was a problem hiding this comment.
This and the others need to be formatted as strings.
|
|
||
| * Add the following steps to "`new WebSocket(url, protocolsOrOptions)` constructor steps" | ||
| after the steps for handling protocols: | ||
| 1. Let |targetAddressSpace| be an [=IP address space=], initially null. |
There was a problem hiding this comment.
We don't state types when initializing variables.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💥 Error: 422 Unprocessable Entity 💥
PR Preview failed to build. (Last tried on Aug 11, 2026, 10:35 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build bikeshed/ReSpec specs
🔗 Related URL
Error output:
[ { "lineNum": "835:41", "messageType": "link", "text": "No 'idl' refs found for 'WebSocketInit'." }, { "lineNum": "478:5", "messageType": "fatal", "text": "Couldn't find target document section rollout-difficulties:\n[[#rollout-difficulties]]" }, { "lineNum": "504:16", "messageType": "fatal", "text": "Couldn't find target document section rollout-difficulties:\n[[#rollout-difficulties]]" }, { "lineNum": "1224:47", "messageType": "fatal", "text": "Couldn't find target document section dns-rebinding:\n[[#dns-rebinding]]" }, { "lineNum": null, "messageType": "failure", "text": "Did not generate, due to errors exceeding the allowed error level." } ]This seems to be an issue with the Spec Generator service. PR Preview doesn't manage this service and so has no control over it. If you've identified an issue with it, you can report the issue to the maintainers of Spec Generator directly. Please be courteous. Thank you!
If you don't have enough information above to solve the error by yourself or if the issue doesn't seem related to Spec Generator, you can file an issue with PR Preview.