ci(nightly): switch GitLab trigger to PIPELINE_TYPE=nightly#1011
Conversation
Set variables[PIPELINE_TYPE]=nightly when triggering the downstream GitLab pipeline so the run no longer requires manual review to release. Rename the Phase 5 job, dispatch input, and printed text from "security scan" to "nightly pipeline" to match what is actually being kicked off. Also fix the dispatch-input gate: skip_gitlab_trigger is typed boolean, so the previous string comparison (\!= 'true') was always truthy and the flag was a no-op. Switch to \!inputs.skip_gitlab_trigger. Closes OPS-6879 Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
Try out this PRQuick install: pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@0befcdb5ec351e66d63707ae3b5f2f9771c807caRecommended with virtual environment (using uv): uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@0befcdb5ec351e66d63707ae3b5f2f9771c807caLast updated for commit: |
WalkthroughThe nightly GitHub Actions workflow is updated to trigger a GitLab nightly pipeline in place of a security scan. A new optional workflow input ChangesNightly Pipeline Trigger Migration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/nightly.yml:
- Around line 42-45: The workflow renamed the workflow_dispatch input to
skip_gitlab_trigger which will break external callers still sending
skip_security_scan or trigger-gitlab-security-scan; add backward-compatible
inputs and coalesce them when deciding to skip: keep the new input
skip_gitlab_trigger, also add inputs skip_security_scan and
trigger-gitlab-security-scan (same boolean default), and update any conditional
logic that checks skip_gitlab_trigger to instead evaluate a coalescing
expression like checking github.event.inputs.skip_gitlab_trigger OR
github.event.inputs.skip_security_scan OR
github.event.inputs['trigger-gitlab-security-scan'] so older callers still work
while preferring the new name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c1e53965-5ab8-4ea3-87c5-cbf98b8ea895
📒 Files selected for processing (1)
.github/workflows/nightly.yml
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
variables[PIPELINE_TYPE]=securitytovariables[PIPELINE_TYPE]=nightlyso the run no longer blocks on manual review.trigger-gitlab-security-scan→trigger-gitlab-nightly-pipeline), dispatch input (skip_security_scan→skip_gitlab_trigger), and all printed text / phase headers / summary table entries to match what's actually being kicked off.type: booleanbut theif:compared it to the string'true', so the skip flag was a no-op. Switched to\!inputs.skip_gitlab_trigger.Closes OPS-6879
Test plan
release=true,skip_gitlab_trigger=false→ confirm GitLab pipeline triggers withPIPELINE_TYPE=nightlyand releases without manual gatingskip_gitlab_trigger=true→ confirm Phase 5 is skipped (was previously not honored)🤖 Generated with Claude Code
Summary by CodeRabbit