Skip to content

ci(nightly): switch GitLab trigger to PIPELINE_TYPE=nightly#1011

Merged
saturley-hall merged 2 commits into
mainfrom
harrison/auto-release-nightly
May 30, 2026
Merged

ci(nightly): switch GitLab trigger to PIPELINE_TYPE=nightly#1011
saturley-hall merged 2 commits into
mainfrom
harrison/auto-release-nightly

Conversation

@saturley-hall

@saturley-hall saturley-hall commented May 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Switch downstream GitLab trigger from variables[PIPELINE_TYPE]=security to variables[PIPELINE_TYPE]=nightly so the run no longer blocks on manual review.
  • Rename the Phase 5 job (trigger-gitlab-security-scantrigger-gitlab-nightly-pipeline), dispatch input (skip_security_scanskip_gitlab_trigger), and all printed text / phase headers / summary table entries to match what's actually being kicked off.
  • Fix a latent bug in the gate: the input is type: boolean but the if: compared it to the string 'true', so the skip flag was a no-op. Switched to \!inputs.skip_gitlab_trigger.

Closes OPS-6879

Test plan

  • Manually dispatch nightly with release=true, skip_gitlab_trigger=false → confirm GitLab pipeline triggers with PIPELINE_TYPE=nightly and releases without manual gating
  • Manually dispatch with skip_gitlab_trigger=true → confirm Phase 5 is skipped (was previously not honored)
  • Scheduled nightly run completes end-to-end and GitLab side runs in the nightly path

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated nightly build workflow to trigger new pipeline type
    • Added emergency control flag to skip automated pipeline triggers when needed

Review Change Stack

Set variables[PIPELINE_TYPE]=nightly when triggering the downstream
GitLab pipeline so the run no longer requires manual review to release.
Rename the Phase 5 job, dispatch input, and printed text from "security
scan" to "nightly pipeline" to match what is actually being kicked off.

Also fix the dispatch-input gate: skip_gitlab_trigger is typed boolean,
so the previous string comparison (\!= 'true') was always truthy and the
flag was a no-op. Switch to \!inputs.skip_gitlab_trigger.

Closes OPS-6879

Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

Try out this PR

Quick install:

pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@0befcdb5ec351e66d63707ae3b5f2f9771c807ca

Recommended with virtual environment (using uv):

uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@0befcdb5ec351e66d63707ae3b5f2f9771c807ca

Last updated for commit: 0befcdbBrowse code

@github-actions github-actions Bot added the ci label May 29, 2026
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The nightly GitHub Actions workflow is updated to trigger a GitLab nightly pipeline in place of a security scan. A new optional workflow input skip_gitlab_trigger allows bypassing the trigger. The job definition, trigger payload variable, logging, and inline comments are all updated to reflect the new pipeline type and job name.

Changes

Nightly Pipeline Trigger Migration

Layer / File(s) Summary
Workflow input and nightly trigger job definition
.github/workflows/nightly.yml
New boolean input skip_gitlab_trigger is added to workflow dispatch inputs. The job trigger-gitlab-security-scan is replaced with trigger-gitlab-nightly-pipeline, including updated needs and if conditions that check the new input and release flag.
GitLab trigger payload and pipeline summary reporting
.github/workflows/nightly.yml
The GitLab trigger step forwards PIPELINE_TYPE=nightly instead of security. Pipeline summary table and logging are updated to report job results and table section labels for the renamed trigger job.
Inline comments and job references
.github/workflows/nightly.yml
Phase comment, build-gating comment, and stage-nightly-container comment are updated to reference trigger-gitlab-nightly-pipeline instead of the prior security-scan job name.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A nightly pipeline blooms where security once stood,
With skip gates and new triggers, as workflows should,
Comments dance and payloads shift their tune,
From scan to nightly runs beneath the moon! 🌙✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately reflects the primary change: switching the GitLab trigger to use PIPELINE_TYPE=nightly instead of security, enabling automatic nightly releases without manual review.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/nightly.yml:
- Around line 42-45: The workflow renamed the workflow_dispatch input to
skip_gitlab_trigger which will break external callers still sending
skip_security_scan or trigger-gitlab-security-scan; add backward-compatible
inputs and coalesce them when deciding to skip: keep the new input
skip_gitlab_trigger, also add inputs skip_security_scan and
trigger-gitlab-security-scan (same boolean default), and update any conditional
logic that checks skip_gitlab_trigger to instead evaluate a coalescing
expression like checking github.event.inputs.skip_gitlab_trigger OR
github.event.inputs.skip_security_scan OR
github.event.inputs['trigger-gitlab-security-scan'] so older callers still work
while preferring the new name.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c1e53965-5ab8-4ea3-87c5-cbf98b8ea895

📥 Commits

Reviewing files that changed from the base of the PR and between a90d154 and 79aa8b8.

📒 Files selected for processing (1)
  • .github/workflows/nightly.yml
Comment thread .github/workflows/nightly.yml
@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@saturley-hall saturley-hall merged commit f9f5a44 into main May 30, 2026
23 of 24 checks passed
@saturley-hall saturley-hall deleted the harrison/auto-release-nightly branch May 30, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants