fix(config): restore profile image source CLI flag#975
Conversation
Restore the flat CLIConfig wiring for --image-source so multimodal profile runs can select noise, bundled assets, or a custom image directory again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Anthony Casagrande <acasagrande@nvidia.com>
Try out this PRQuick install: pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@dfbd4d2c295bc4381cd09ad3122d8f4f4ce6beb9Recommended with virtual environment (using uv): uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@dfbd4d2c295bc4381cd09ad3122d8f4f4ce6beb9Last updated for commit: |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR introduces a new ChangesImage Source CLI Option
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Reject --image-source alongside --input-file so synthetic image generation options cannot be silently ignored on file-backed datasets. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Anthony Casagrande <acasagrande@nvidia.com>
Keep adversarial YAML nesting above AIPerf's depth guard without forcing PyYAML into interpreter recursion warnings, and make the rate-limiting invariant assert overshoot instead of CI runner throughput. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Anthony Casagrande <acasagrande@nvidia.com>
Summary
--image-sourceto the flat profile CLI config schema with the current default-noise behavior.benchmark.dataset.images.sourceand include them in input field tracking.noiseand custom directory sources.Test plan
uv run pytest -n auto tests/unit/config/test_cli_image_source.pyuv run ruff format src/aiperf/config/flags/cli_config.py src/aiperf/config/flags/_converter_dataset.py src/aiperf/config/flags/_section_fields.py tests/unit/config/test_cli_image_source.py && uv run ruff check --fix src/aiperf/config/flags/cli_config.py src/aiperf/config/flags/_converter_dataset.py src/aiperf/config/flags/_section_fields.py tests/unit/config/test_cli_image_source.pyuv run pytest -n auto tests/unit/🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
--image-sourceCLI option to configure how images are sourced during benchmarking: on-the-fly noise generation, built-in assets, or a custom directory. Defaults to noise.Tests