chore(rename): ARTIFACTORY_REPO_NAME -> ARTIFACTORY_PYPI_REPO_NAME#978
Conversation
… trigger Match the existing ARTIFACTORY_PYPI_URL secret naming so the PyPI-repo scoping is explicit in both the GitHub secret reference and the GitLab variable forwarded by the nightly trigger. Follow-up to #973. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
Try out this PRQuick install: pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@06796de7015fef3c238e89d9359991b8cbef6255Recommended with virtual environment (using uv): uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@06796de7015fef3c238e89d9359991b8cbef6255Last updated for commit: |
WalkthroughThe nightly workflow's ChangesGitLab trigger secret rename
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
Follow-up to #973. Rename the GitHub secret reference and the GitLab pipeline variable from
ARTIFACTORY_REPO_NAMEtoARTIFACTORY_PYPI_REPO_NAMEso the PyPI-repo scoping is explicit and the naming matches the siblingARTIFACTORY_PYPI_URLsecret.The env block in the
Trigger GitLab pipelinestep is realigned to accommodate the new (longest) key. No behavioral change beyond the rename and the corresponding env-block whitespace.Test plan
automated-releaseenvironment has theARTIFACTORY_PYPI_REPO_NAMEsecret populated (rename or duplicate from the oldARTIFACTORY_REPO_NAMEbefore merging this PR).workflow_dispatchand verify theTrigger GitLab pipelinestep's env dump showsARTIFACTORY_PYPI_REPO_NAMEmasked (***) — not empty.ARTIFACTORY_PYPI_REPO_NAMEpopulated.🤖 Generated with Claude Code
Summary by CodeRabbit