Skip to content

chore(rename): ARTIFACTORY_REPO_NAME -> ARTIFACTORY_PYPI_REPO_NAME#978

Merged
ajcasagrande merged 1 commit into
mainfrom
harrison/increase-release-outputs
May 22, 2026
Merged

chore(rename): ARTIFACTORY_REPO_NAME -> ARTIFACTORY_PYPI_REPO_NAME#978
ajcasagrande merged 1 commit into
mainfrom
harrison/increase-release-outputs

Conversation

@saturley-hall

@saturley-hall saturley-hall commented May 21, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to #973. Rename the GitHub secret reference and the GitLab pipeline variable from ARTIFACTORY_REPO_NAME to ARTIFACTORY_PYPI_REPO_NAME so the PyPI-repo scoping is explicit and the naming matches the sibling ARTIFACTORY_PYPI_URL secret.

The env block in the Trigger GitLab pipeline step is realigned to accommodate the new (longest) key. No behavioral change beyond the rename and the corresponding env-block whitespace.

Test plan

  • Confirm the automated-release environment has the ARTIFACTORY_PYPI_REPO_NAME secret populated (rename or duplicate from the old ARTIFACTORY_REPO_NAME before merging this PR).
  • After merge, trigger a manual nightly via workflow_dispatch and verify the Trigger GitLab pipeline step's env dump shows ARTIFACTORY_PYPI_REPO_NAME masked (***) — not empty.
  • Confirm the downstream GitLab compliance pipeline now sees ARTIFACTORY_PYPI_REPO_NAME populated.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated nightly workflow configuration to align security scan trigger with current environment variable naming conventions.

Review Change Stack

… trigger

Match the existing ARTIFACTORY_PYPI_URL secret naming so the PyPI-repo
scoping is explicit in both the GitHub secret reference and the GitLab
variable forwarded by the nightly trigger.

Follow-up to #973.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
@github-actions

Copy link
Copy Markdown

Try out this PR

Quick install:

pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@06796de7015fef3c238e89d9359991b8cbef6255

Recommended with virtual environment (using uv):

uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@06796de7015fef3c238e89d9359991b8cbef6255

Last updated for commit: 06796deBrowse code

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The nightly workflow's trigger-gitlab-security-scan job is updated to reference a renamed secret. The job environment variable and the curl request form variable now both use ARTIFACTORY_PYPI_REPO_NAME instead of ARTIFACTORY_REPO_NAME, aligning the trigger payload with the new expected secret name.

Changes

GitLab trigger secret rename

Layer / File(s) Summary
GitLab trigger secret variable update
.github/workflows/nightly.yml
Job env: mapping updated to source ARTIFACTORY_PYPI_REPO_NAME from secrets instead of ARTIFACTORY_REPO_NAME, and the curl request form variables updated to submit the renamed variable in the GitLab trigger payload.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The secrets have been renamed with care,
PyPI now proud in its variable pair,
From old names to new, a swift curl command flows,
The nightly scan triggers wherever it goes! 🌙✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and specifically summarizes the main change: renaming a GitHub secret and GitLab variable from ARTIFACTORY_REPO_NAME to ARTIFACTORY_PYPI_REPO_NAME, which aligns with the changeset and PR objectives.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ajcasagrande ajcasagrande changed the title rename: ARTIFACTORY_REPO_NAME -> ARTIFACTORY_PYPI_REPO_NAME May 22, 2026
@github-actions github-actions Bot added the chore label May 22, 2026
@ajcasagrande ajcasagrande merged commit 193789c into main May 22, 2026
25 of 27 checks passed
@ajcasagrande ajcasagrande deleted the harrison/increase-release-outputs branch May 22, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants