Skip to content

Code made compatible with Airbnb style guide#2806

Draft
0o001 wants to merge 4 commits into
airbnb:masterfrom
0o001:master
Draft

Code made compatible with Airbnb style guide#2806
0o001 wants to merge 4 commits into
airbnb:masterfrom
0o001:master

Conversation

@0o001

@0o001 0o001 commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

Add arrays bracket newline
https://github.com/airbnb/javascript#arrays--bracket-newline

Add array destructuring
https://github.com/airbnb/javascript#destructuring--array

And severities array put inside the getSeverity function

@ljharb ljharb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is enforcing this change?

Comment thread packages/eslint-config-airbnb-base/whitespace.js Outdated
Comment thread packages/eslint-config-airbnb/whitespace-async.js Outdated
@0o001

0o001 commented Aug 7, 2023

Copy link
Copy Markdown
Contributor Author

What is enforcing this change?

I wanted to align the used codes with the format recommended in Airbnb's own style guide.

@ljharb

ljharb commented Aug 7, 2023

Copy link
Copy Markdown
Collaborator

Right, but our own eslint rules in this project should be enforcing that, rather than doing it manually.

@ljharb ljharb marked this pull request as draft August 15, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants