feat(build): add required owner_team field to template entries#832
Open
Aydin-ab wants to merge 2 commits into
Open
feat(build): add required owner_team field to template entries#832Aydin-ab wants to merge 2 commits into
Aydin-ab wants to merge 2 commits into
Conversation
Templates had no ownership metadata. Add owner_team (single enum value, deduced from each template's content) to every BUILD.yaml entry so each template records its owning team; `general` covers platform/Ray Core/ onboarding content with no single-library owner. Required + enum-validated in check-build-yaml. Claude-Session: https://claude.ai/code/session_01EHmdjcZkcUaczQSFQD848V Signed-off-by: Aydin Abiar <aydin@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
owner_teamfield to every BUILD.yaml template entry so each template records its owning team, deduced from content.What changed
ci/validate_build_yaml.py—owner_teamrequired + enum-validated (ray-serve|ray-data|llm|ray-train|general) on every entry; schema errors now name the entry (e.g.job-intro.owner_team: …) instead of a positional index.BUILD.yaml— backfilled all 56 entries. Distribution: ray-train 17, ray-data/llm/general 10 each, ray-serve 9./templateskill — field + deduction rule/tie-break inschemas/build-yaml-schema.yaml, with pointers fromSKILL.md,workflows/create-template.md,references/conventions.md.Why
No ownership metadata existed.
generalcovers platform / Ray Core / onboarding templates (intros, multi-library surveys, pure Ray Core) that have no single-library owner.Notes
object-detection-video-processing→ ray-train,audio-dataset-curation-llm-judge→ llm.rayapp build all(premergebuildjob) parses BUILD.yaml but couldn't run on macOS; Go YAML ignores unknown keys by default, so it should tolerateowner_team— CI is the definitive check.Testing
pre-commitgreen (incl.check-build-yaml).owner_teamvalues.https://claude.ai/code/session_01EHmdjcZkcUaczQSFQD848V