SQLite: Support comma-separated WITHOUT ROWID and STRICT table options - #2575
Open
LucaCappelletti94 wants to merge 4 commits into
Open
LucaCappelletti94 wants to merge 4 commits into
LucaCappelletti94 wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2575 +/- ##
==========================================
+ Coverage 81.02% 81.05% +0.03%
==========================================
Files 42 42
Lines 33436 33616 +180
Branches 33436 33616 +180
==========================================
+ Hits 27090 27247 +157
- Misses 2789 2800 +11
- Partials 3557 3569 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
marked this pull request as ready for review
September 24, 2026 22:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite ends
CREATE TABLEwith a comma-separated list of table options,WITHOUT ROWIDandSTRICT, in any order and optionally preceded by a comma (SQLite docs).The parser read the two keywords at unrelated points of the statement, so
CREATE TABLE a (id INTEGER PRIMARY KEY) WITHOUT ROWID, STRICT, its reverse and(...), STRICTfailed to parse. The one spelling it accepted,WITHOUT ROWID STRICT, is one SQLite refuses, and a table with both options rendered back to it.The
without_rowidandstrictflags onCreateTablebecome onesqlite_table_optionsfield holding the options in source order and whether a comma precedes them. Output therefore matches input, which matters because SQLite stores that text verbatim insqlite_schema. The comma-less spelling now fails as it does in SQLite. #208 and #898 added each option on its own.