Spark 3.4: Migrate tests in sql#12934
Merged
Merged
Conversation
Contributor
Author
|
@nastra Sorry for the delay, could you review this when you have a chance? I believe one or two PRs will complete the |
nastra
reviewed
Apr 30, 2025
| @TestTemplate | ||
| public void testDefaultNamespace() { | ||
| assumeThat(isHadoopCatalog).as("Hadoop has no default namespace configured").isFalse(); | ||
| assumeThat(catalogConfig.get(ICEBERG_CATALOG_TYPE)) |
Contributor
There was a problem hiding this comment.
I'm a little surprised to see this change here. Can you elaborate why this is being added here?
Contributor
Author
nastra
reviewed
Apr 30, 2025
| .as("Should have only db namespace") | ||
| .isEqualTo(ImmutableSet.of("db")); | ||
| if (isHadoopCatalog | ||
| || catalogConfig.get(ICEBERG_CATALOG_TYPE).equals(ICEBERG_CATALOG_TYPE_REST)) { |
Contributor
There was a problem hiding this comment.
why is this check for REST being added here? we're not testing with REST in this class, so I'm surprised to see this
Contributor
Author
There was a problem hiding this comment.
As well as my reply above, this line also is only for Spark 3.4, and it's no longer needed. Let me remove this as well. Thanks so much for pointing this.
nastra
approved these changes
Apr 30, 2025
Contributor
Author
|
@nastra Thanks so much for the review! |
anuragmantri
added a commit
to anuragmantri/iceberg
that referenced
this pull request
Jul 25, 2025
Co-authored-by: Tom Tanaka <43331405+tomtongue@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate Spark 3.4 tests based on JUnit 4 to Junit5 with AssertJ style. This is related to #7160
This PR migrates the following Spark 3.4 tests in the
spark.sqlpackage to JUnit 5 with AssertJ:TestAggregatePushDownTestCreateTableTestCreateTableAsSelectTestDeleteFromTestDropTableTestFilterPushDownTestNamespaceSQLTestRefreshTableTestSelect