use Files.createTempFile for s/mime backing temp files#2326
Open
rootvector2 wants to merge 1 commit into
Open
Conversation
hubot
pushed a commit
that referenced
this pull request
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SMIMEUtilandSMIMESignedParserspool decrypted, decompressed and signed S/MIME content to a backing file created withFile.createTempFile, which honors the umask and lands at mode0644on a normal POSIX box. The spooled bytes are plaintext, so on a shared host any local user can read a decrypted message out of the temp dir before it gets cleaned up. Found while auditing the temp-file paths in the mail module.Switch the four sites to
Files.createTempFile, which creates the file0600on POSIX and owner-only on Windows. Keeping the restriction in the helpers means every caller going throughtoMimeBodyPart/toWriteOnceBodyPart/ the parser temp file gets it without each one re-deriving the check.