Skip to content

Review codebase for PipelineExecutionData exit status usage #125

Description

@cablehead

Nushell main now returns PipelineExecutionData from eval_block_with_early_return, which includes:

  • .body: the PipelineData (what we currently extract and use)
  • .exit: Vec<Option<(Arc<Mutex<ExitStatusFuture>>, Span)>> (currently ignored)

We should review the codebase to determine if/where we should be checking or propagating these exit statuses, particularly in:

  • src/nu/engine.rs: eval(), parse_closure(), run_closure_in_job()
  • src/nu/config.rs: config loading

Related to upgrade to nushell main branch.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions